Bug 1872660

Summary: [machines] There is an 'Ooops' when input something to 'Target Path' on 'Storage Pool' creation dialog
Product: Red Hat Enterprise Linux 8 Reporter: YunmingYang <yunyang>
Component: cockpit-appstreamAssignee: Katerina Koukiou <kkoukiou>
Status: CLOSED ERRATA QA Contact: YunmingYang <yunyang>
Severity: high Docs Contact:
Priority: unspecified    
Version: 8.3CC: leiwang, mmarusak, mpitt, skobyda, wshi, xchen, ymao
Target Milestone: rcKeywords: Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: 237 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:53:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description YunmingYang 2020-08-26 10:30:17 UTC
Description of problem:
There will be an 'Ooops' when inputting something by 'Ctrl + C' and 'Ctrl + V' to 'Target Path' on 'Storage Pool' creation dialog.

Version-Release number of selected components (if applicable):
cockpit-machines-224.2-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Open the 'Storage Pool' creation dialog
2. Copy a path(such as /home/test) to 'Target Path' by 'Ctrl + C' and 'Ctrl + V'
3. Then input 'Arrow Down' by keyboard

Actual results:
1. After step 2, the drop-down list doesn't show the input option(The path exists on the host)
2. After step 3, there will be an 'Ooops' shown

Expected results: 
1. After step 2, the drop-down list show the input option
2. After step 3, no 'Ooops' shown

Additional info:
Error message from browser  console:
machines.js:114 Uncaught TypeError: Cannot read property 'classList' of null
    at handleTypeaheadKeys (machines.js:114)
    at onKeyDown (machines.js:114)
    at Object.s (machines.js:98)
    at f (machines.js:98)
    at machines.js:98
    at v (machines.js:98)
    at at (machines.js:98)
    at it (machines.js:98)
    at st (machines.js:98)
    at ft (machines.js:98)

Comment 2 Katerina Koukiou 2021-01-26 15:54:23 UTC
PR sent upstream but it's blocked on some patternfly-react open patches. https://github.com/cockpit-project/cockpit/pull/15219

Comment 5 Katerina Koukiou 2021-02-02 11:08:10 UTC
Fixed with:

commit 7d44ac7b93223bcd86ea748ec548948fc0f397f7
Author: Katerina Koukiou <kkoukiou>
Date:   Tue Feb 2 11:21:06 2021 +0100

    lib: improve our custom FileAutocomplete component

Comment 8 YunmingYang 2021-02-07 08:23:25 UTC
Test Versions:
cockpit-machines-237-1.el8.noarch
cockpit-236-1.el8.x86_64
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64


Test Steps:
1. Open the 'Storage Pool' creation dialog
2. Copy a path(such as /home/test) to 'Target Path' by 'Ctrl + C' and 'Ctrl + V'
3. Then input 'Arrow Down' by keyboard

Test Results:
1. After step 2, the drop-down list show the input option
2. After step 3, no 'Ooops' shown.

According to the results, move the status to VERIFIED.

Comment 10 errata-xmlrpc 2021-05-18 15:53:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1875