Bug 1872753

Summary:	lsmcli mentions 'service' command rather than 'systemctl'
Product:	Red Hat Enterprise Linux 8	Reporter:	John Pittman <jpittman>
Component:	libstoragemgmt	Assignee:	Tony Asleson <tasleson>
Status:	CLOSED ERRATA	QA Contact:	ChanghuiZhong <czhong>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	cwei
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.4
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 14:56:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description John Pittman 2020-08-26 14:48:17 UTC

Description of problem:

lsmcli mentions 'service' command rather than 'systemctl'

[root@localhost ~]# lsmcli -u hpsa:// ld
DAEMON_NOT_RUNNING(12): The libStorageMgmt daemon is not running (process name lsmd), try 'service libstoragemgmt start' 

Version-Release number of selected component (if applicable):

libstoragemgmt-1.8.3-1.el8.x86_64

How reproducible:

every time

Steps to reproduce:

Run lsmcli without libstoragemgmt daemon started

Actual results:

try 'service libstoragemgmt start' 

Expected results:

try 'systemctl start libstoragemgmt'

Comment 2 Tony Asleson 2020-08-26 15:07:51 UTC

lsmd is used from RHEL6 - Fedora.  While technically 'systemctl start libstoragemgmt' 
would be more correct in some cases, the 'service libstoragemgmt [start|status|stop]
does work on all as it gets re-directed to systemctl.

I'm thinking that is might be better to just remove "try 'service libstoragemgmt start'"
instead of adding logic to determine which hint text is more appropriate for the
given system.

Comment 4 Tony Asleson 2020-10-26 14:59:48 UTC

$ git diff HEAD~1
diff --git a/python_binding/lsm/_client.py b/python_binding/lsm/_client.py
index e18c29e..22b8f0f 100644
--- a/python_binding/lsm/_client.py
+++ b/python_binding/lsm/_client.py
@@ -51,7 +51,7 @@ def _check_search_key(search_key, supported_keys):
 def _raise_no_daemon():
     raise LsmError(ErrorNumber.DAEMON_NOT_RUNNING,
                    "The libStorageMgmt daemon is not running (process "
-                   "name lsmd), try 'service libstoragemgmt start'")
+                   "name lsmd), please start service")

Comment 8 ChanghuiZhong 2020-11-11 09:14:40 UTC

Confirm that libstoragemgmt-1.8.6-1.el8 has used "please start service" instead of "try'service libstoragemgmt start'" as the hint text.

# lsmcli -u hpsa:// ld
DAEMON_NOT_RUNNING(12): The libStorageMgmt daemon is not running (process name lsmd), please start service 

# rpm -q libstoragemgmt
libstoragemgmt-1.8.6-1.el8.x86_64

Comment 10 errata-xmlrpc 2021-05-18 14:56:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libstoragemgmt bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1629