Bug 1873246

Summary:	[RFE] --stack-only should re-generate Ansible content
Product:	Red Hat OpenStack	Reporter:	Luke Short <lshort>
Component:	python-tripleoclient	Assignee:	OSP Team <rhos-maint>
Status:	CLOSED ERRATA	QA Contact:	David Rosenfeld <drosenfe>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	17.0 (Wallaby)	CC:	bdobreli, cjeanner, emacchi, grosenbe, hbrock, jschluet, jslagle, mariel, mbarnett, mburns, nlevinki, pweeks, ramishra, spower
Target Milestone:	Alpha	Keywords:	FutureFeature, Triaged
Target Release:	17.0	Flags:	grosenbe: needinfo-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-tripleoclient-16.4.1-0.20211008042333.f3d167d.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-21 12:11:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luke Short 2020-08-27 17:25:28 UTC

Description of problem:
The `openstack overcloud deploy --stack-only` command will only update the Heat stack. It does NOT update the config-download playbooks. Running the `openstack overcloud deploy --config-download-only` command will run the deployment using the config-download Ansible content that was generated based on the last Heat stack (not the current one).


Version-Release number of selected component (if applicable):
All RHOSP releases


How reproducible:
100%


Steps to Reproduce:
1. Update a TripleO Heat template parameter
2. `openstack overcloud deploy --stack-only`
3. `openstack overcloud deploy --config-download-only`


Actual results:
The updated Heat stack is not used to generate new Ansible content.


Expected results:
The new Heat parameters should be picked up and used for the config-download run.

Comment 3 Luke Short 2020-08-27 17:28:09 UTC

This feature should also be extended to include `openstack overcloud config download`.

Comment 4 Luke Short 2020-08-27 17:39:19 UTC

Or rather, `openstack overcloud deploy --stack-only` should generate the Ansible deployment content.

Comment 7 Bogdan Dobrelya 2020-09-10 08:57:22 UTC

Also note that given that `openstack overcloud deploy --stack-only` should generate the Ansible deployment content, having both that and `openstack overcloud config download` looks redundant. Those two should be merged into a single command.

Comment 12 Kevin Carter 2021-01-27 14:47:54 UTC

An implementation of this RFE has been submitted upstream - linked here [0].

This change implements a new option called `setup-only` which allows the user to omit the `stack-only` flag. This change implements the setup automation required to allow the deployer to run ansible-playbook directly.

[0] https://review.opendev.org/c/openstack/python-tripleoclient/+/772701

Comment 13 Cédric Jeanneret 2021-02-17 14:52:35 UTC

Moving to osp-17 since patch still open upstream, and we're too close to the deadlines for 16.2.

Comment 21 David Rosenfeld 2022-07-13 14:56:52 UTC

Test cases pass and automation is in place.

Comment 26 errata-xmlrpc 2022-09-21 12:11:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.0 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:6543