Bug 187326
Summary: | Review Request: smokeping - Network latency grapher | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | axel.thimm, curtis, yaneti |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-22 19:24:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 187304, 187313 | ||
Bug Blocks: |
Description
Andreas Thienemann
2006-03-30 01:51:05 UTC
rpmlint gives several errors and warnings, which should be ignored: E: smokeping only-non-binary-in-usr-lib rpmlint seems to have problems with perl modules E: smokeping non-readable /etc/smokeping/tmail 0640 Contains passwords. E: smokeping non-standard-gid /var/lib/smokeping/images apache Must be apache writeable. E: smokeping non-standard-dir-perm /var/lib/smokeping/images 0775 Same. E: smokeping non-readable /etc/smokeping/smokemail 0640 Again passwords. E: smokeping non-standard-gid /etc/smokeping/config apache Apachereadable. E: smokeping non-readable /etc/smokeping/config 0640 Passwords again. I've not yet collected enough ROUND TUITs to get more involved in FE. But from 2002 through 2004 I maintained a working smokeping RPM For Red Hat. I also kept an rpm for the speedy cgi helper. http://www.greenkey.net/~curtis/rpm/src/SPECPATCH/smokeping-1.27/smokeping.spec http://www.greenkey.net/~curtis/rpm/src/SPECPATCH/perl-PersistentPerl-2.22/perperl.spec http://www.greenkey.net/~curtis/rpm/src/smokeping-1.27-gk1.src.rpm http://www.greenkey.net/~curtis/rpm/src/perl-PersistentPerl-2.22-1gk1.src.rpm They are stylistically very different than yours. But maybe some stuff would be helpfull to compare and integrate still... Like a handy bit o' perl as an rpm macro that cleans up the path rather than using a patch for every release. Or the nice basic starting config that monitors the local server; *NOT* the same bunch of static sites across the net. That's not cool. Stuff like the apache-1.3 %trigger is clearly outdated, though. A few patches from it's earlier days have already swam upstream. Please feel free to peruse and integrate. :-) (In reply to comment #1) > rpmlint gives several errors and warnings, which should be ignored: > > E: smokeping only-non-binary-in-usr-lib > rpmlint seems to have problems with perl modules These would probably go away if the perl modules were installed into %{perl_vendorlib} rather than %{_libdir}/smokeping That should also remove the need for the various explicit paths needed in "use lib" statements here and there, since perl would look for the modules in the right place by default. (In reply to comment #2) > I also kept an rpm for the speedy cgi helper. Ahh, that is interesting. I'll take a look at it sometime and see how to incorporate it. > Like a handy bit o' perl as an rpm macro that cleans up the path rather than > using a patch for every release. Yeah. I called perl directly at first but then decided to prefer an external patch, as it is cleaner. And from what I gathered, the different upstream versions don't differ that much, that each new release would need a new patch. In case that should prove to be false, I'll incorporate your decruft() call. ;) > Or the nice basic starting config that monitors the local server; *NOT* the > same bunch of static sites across the net. That's not cool. Yes, that looks like a nice feature, to have tailored configuration for the lokal net, right out of the box. But I am not that sure, if it is such a good idea. RedHat has in the past kept their config files more general and leave the configuration to the local admin. Not as debian, which does a lot of configuration at package installation time through debhelper. Furthermore, I think grepping through the output of the route command is a bit risky, as it's prone to fail if the system has no network yet or could pick up the wrong systems if the laptop is somewhere else. If other people think, that is a good idea to implement something, I can do that. But right now, I prefer to leave that to the enduser. > A few patches from it's earlier days have already swam upstream. Please feel > free to peruse and integrate. :-) :-D (In reply to comment #3) > > rpmlint seems to have problems with perl modules > These would probably go away if the perl modules were installed into > %{perl_vendorlib} rather than %{_libdir}/smokeping > That should also remove the need for the various explicit paths needed in "use > lib" statements here and there, since perl would look for the modules in the > right place by default. Good idea. The smokeping modules are in the %{perl_vendorlib}/Smokeping now and the specific use lib calls can be removed from the binaries. However it seems a small wrapper script is needed now in order to prevent cluttering and potential conflicts in %{perl_vendorlib}. My knowledge of perl modules is extremely limited, it would be nice if someone could take a look at %{SOURCE4} and see if there's an easier way. The drawback is, that the wrapperscript calles Smokeping::Smokeping which get's picked up as a dependency. I put a provide with perl(Smokeping::Smokeping) into the spec, which rpmlint thinks is needless explicit. This is defintly wrong. Suggestions? Spec Name or Url: http://home.bawue.net/~ixs/smokeping/smokeping.spec SRPM Name or Url: http://home.bawue.net/~ixs/smokeping/smokeping-2.0.7-3.src.rpm comments from a total selinux newbie perspective. It does not seem to be ready for an apache running under enforcing selinux policy. I bumped into this under FC4. The first symptom was "ERROR: /etc/smokeping/config, line 11: Directory '/var/lib/smokeping/images' does not exist" Had to change the context of the cgi script and the data and imgcache directories. Also AFAIK from a selinux perspective its better for the pid file to be in its own directory eg. /var/run/smokeping/smokeping.pid which requires changes to the default config. Since smokeping runs as a daemon, I guess the smokeping binary should be in /usr/sbin instead of /usr/bin (In reply to comment #7) > Since smokeping runs as a daemon, I guess the smokeping binary should be in > /usr/sbin instead of /usr/bin A daemon needs not be in /usr/sbin, what goes in /usr/sbin is what is exclusively run by root, in general because it requires some privilege. Andreas, do you still want to try to get this in? Tibbs, sure. I've just gotten back from my vacation... Care to do a review after I updated the package to current versions? I am just in the need for a packaged smokeping, so I'd gladly review it if tibbs is bored :) sounds good. ;D Just gimme a day or four... ;D Axel, there are plenty of other packages I can review so please do take this. So what happened? Axel assigned this to himself a month ago, but this ticket still blocks FE-NEW and no progress has been made. Andreas wanted to update the package before the review, I've been waiting for that to happen. I'll revert the assignment to better reflect the current status. Yeah. Sorry for the delay. I spent the last weeks in ireland with no ip access there. Right now I'm at akademy, the kde conference in dublin. I guess, I'll manage to fix the package up here. No progress in many months now; I'm closing this review. *** This bug has been marked as a duplicate of 441378 *** |