Bug 1873373

Summary:	Review Request: crash-gcore-command - Gcore extension module for the crash utility
Product:	[Fedora] Fedora	Reporter:	lijiang
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bhe, dyoung, package-review, zebob.m
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-07 02:09:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description lijiang 2020-08-28 04:36:40 UTC

Description:

Spec URL: https://github.com/lian-bo/fedora-crash-gcore-command/blob/master/crash-gcore-command.spec

SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9727/50289727/crash-gcore-command-1.5.1-1.fc34.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50289726

Description: The crash-gcore-command packages contain an extension module for the crash utility that adds a "gcore" command which can create a core dump file of a user-space task that was running in a kernel dumpfile.

In addition, I also maintain the crash-utility in Fedora and upstream.

Thanks for your attention.

Fedora Account System Username: lijiang

Comment 1 Robert-André Mauchin 🐧 2020-08-28 16:12:34 UTC

 - This is not used in Fedora:

Group: Development/Debuggers

 - The link to the archive is not valid:

Source: https://github.com/crash-utility/crash-extensions/raw/master/%{name}-%{version}.tar.gz

Also uploading binary archive straight to git is a bad idea. It would be better to tag a release.
Everyone cloning the repo wall have to download the binary even if you delete it later. It could be purged from history but I don't know the exact procedure.

 - Not needed:

ExclusiveOS: Linux

 - ExclusiveArch: x86_64 %{ix86} arm aarch64 ppc64 ppc64le → ExclusiveArch: x86_64 %{ix86} %{arm} aarch64 ppc64 ppc64le

 - Split your BR one per line, consider using pkgconfig() for your devel dependency:

BuildRequires: crash-devel >= 5.1.5
BuildRequires: pkgconfig(zlib)
BuildRequires: pkgconfig(lzo2)
BuildRequires: pkgconfig(snappy)

 - Not needed:

rm -Rf $RPM_BUILD_ROO

%clean
rm -rf %{buildroot}
rm -Rf $RPM_BUILD_ROOT


%defattr(-,root,root)

 - License file must be installed with %license not %doc

%license COPYING

 - You need to make sure Fedora build flags are used for the build.

Use %set_build_flags to set them up.

%build
%set_build_flags
%make_build -f gcore.mk

 - make -f gcore.mk → %make_build -f gcore.mk

 - please use install to create and install file at the right place:

install -m 0755 -vd                     %{buildroot}%{_libdir}/crash/extensions/
install -m 0755 -vp gcore.so            %{buildroot}%{_libdir}/crash/extensions/

Comment 2 lijiang 2020-09-04 11:57:31 UTC

Hi, Robert-André Mauchin

Thank you for helping to review this.

Based on our internal team's discussion(and on upstream), we would like to give up adding the crash extensions packages to the Fedora because no one uses them in the Fedora, currently, only Fujitsu engineers use them in RHEL. So, I will close this bug.

Thanks for your help, Robert-André Mauchin.