Bug 1873698

Summary: ovsdb: support to modify external_ids of system interface
Product: Red Hat Enterprise Linux 8 Reporter: Mingyu Shi <mshi>
Component: nmstateAssignee: Gris Ge <fge>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: ferferna, jiji, jishi, network-qe, till
Target Milestone: rcKeywords: Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:17:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
beaker.log none

Description Mingyu Shi 2020-08-29 09:49:25 UTC
Description of problem:
With ovsdb plugin, now we can configure user-defined external_ids on ovs bridge and ovs internal interface, but it fails when doing that on a system type interface.
Executed "ovs-vsctl set interface $sysiface external_ids:$key=$value", nmstate could show it.

Version-Release number of selected component (if applicable):
Verified with versions:
nmstate-0.3.4-12.el8.noarch
NetworkManager-1.26.0-6.el8.x86_64
DISTRO=RHEL-8.3.0-20200824.n.0
Linux sun-x5-2l-1.gsslab.rdu2.redhat.com 4.18.0-234.el8.x86_64 #1 SMP Thu Aug 20 10:25:32 EDT 2020 x86_64 x86_64 x86_64 GNU/Linux
openvswitch2.13-2.13.0-39.el8fdp.x86_64
openvswitch-selinux-extra-policy-1.0-22.el8fdp.noarch
python3-openvswitch2.13-2.13.0-39.el8fdp.x86_64


How reproducible:
100%

Steps to Reproduce:
cat << EOF > setup.yaml 
interfaces:
- name: ovs-br0
  type: ovs-bridge
  state: up
  bridge:
    port:
    - name: ovs0
    - name: dummy0
- name: dummy0
  type: dummy
  state: up
EOF
nmstatectl set setup.yaml
nmstatectl show dummy0 #NM UUID is shown under external_ids
cat << EOF > ovsdb.yaml 
interfaces:
- name: dummy0
  type: dummy
  state: up
  ovs-db:
   external_ids:
     test: this
EOF
nmstatectl set ovsdb.yaml


Actual results:
Failed

Expected results:
No failure

Additional info:
[17:43:53@sun-x5-2l-1 ~]0# nmstatectl set ovsdb.yaml
2020-08-29 17:43:56,061 root         DEBUG    Async action: Create checkpoint started
2020-08-29 17:43:56,064 root         DEBUG    Checkpoint None created for all devices
2020-08-29 17:43:56,064 root         DEBUG    Async action: Create checkpoint finished
2020-08-29 17:43:56,066 root         DEBUG    Async action: Update profile: dummy0 started
2020-08-29 17:43:56,066 root         DEBUG    Async action: Update profile: ovs-port-dummy0 started
2020-08-29 17:43:56,086 root         DEBUG    Async action: Update profile: dummy0 finished
2020-08-29 17:43:56,098 root         DEBUG    Async action: Update profile: ovs-port-dummy0 finished
2020-08-29 17:43:56,099 root         DEBUG    Async action: Reapply device config: ovs-port-dummy0 started
2020-08-29 17:43:56,099 root         DEBUG    Async action: Reapply device config: dummy0 started
2020-08-29 17:43:56,100 root         DEBUG    Async action: Reapply device config: ovs-port-dummy0 finished
2020-08-29 17:43:56,101 root         DEBUG    Async action: Reapply device config: dummy0 finished
2020-08-29 17:44:01,233 root         DEBUG    Async action: Rollback to checkpoint /org/freedesktop/NetworkManager/Checkpoint/196 started
2020-08-29 17:44:01,250 root         DEBUG    Checkpoint /org/freedesktop/NetworkManager/Checkpoint/196 rollback executed
2020-08-29 17:44:01,251 root         DEBUG    Interface eno2 rollback succeeded
2020-08-29 17:44:01,251 root         DEBUG    Interface veth0_ep rollback succeeded
2020-08-29 17:44:01,251 root         DEBUG    Interface veth1 rollback succeeded
2020-08-29 17:44:01,251 root         DEBUG    Interface ovs-port-dummy0 rollback succeeded
2020-08-29 17:44:01,251 root         DEBUG    Interface ovs-br0 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface eno3 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface lo rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface eno4 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface eno1 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface ovs0 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface enp0s29u1u8c2 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface veth0 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Async action: Waiting for rolling back dummy0 started
2020-08-29 17:44:01,252 root         DEBUG    Interface dummy0 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface ovs-port-ovs0 rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Interface veth1_ep rollback succeeded
2020-08-29 17:44:01,252 root         DEBUG    Async action: Rollback to checkpoint /org/freedesktop/NetworkManager/Checkpoint/196 finished
2020-08-29 17:44:01,254 root         DEBUG    Active connection of device None has been replaced
2020-08-29 17:44:01,257 root         DEBUG    Connection activation succeeded: dev=dummy0, con-state=<enum NM_ACTIVE_CONNECTION_STATE_ACTIVATED of type NM.ActiveConnectionState>, dev-state=<enum NM_DEVICE_STATE_ACTIVATED of type NM.DeviceState>, state-flags=<flags NM_ACTIVATION_STATE_FLAG_IS_SLAVE | NM_ACTIVATION_STATE_FLAG_LAYER2_READY | NM_ACTIVATION_STATE_FLAG_IP4_READY | NM_ACTIVATION_STATE_FLAG_IP6_READY of type NM.ActivationStateFlags>
2020-08-29 17:44:01,258 root         DEBUG    Async action: Waiting for rolling back dummy0 finished
Traceback (most recent call last):
  File "/usr/bin/nmstatectl", line 11, in <module>
    load_entry_point('nmstate==0.3.4', 'console_scripts', 'nmstatectl')()
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 67, in main
    return args.func(args)
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 256, in apply
    args.save_to_disk,
  File "/usr/lib/python3.6/site-packages/nmstatectl/nmstatectl.py", line 289, in apply_state
    save_to_disk=save_to_disk,
  File "/usr/lib/python3.6/site-packages/libnmstate/netapplier.py", line 71, in apply
    _apply_ifaces_state(plugins, net_state, verify_change, save_to_disk)
  File "/usr/lib/python3.6/site-packages/libnmstate/netapplier.py", line 115, in _apply_ifaces_state
    _verify_change(plugins, net_state)
  File "/usr/lib/python3.6/site-packages/libnmstate/netapplier.py", line 120, in _verify_change
    net_state.verify(current_state)
  File "/usr/lib/python3.6/site-packages/libnmstate/net_state.py", line 63, in verify
    self._ifaces.verify(current_state.get(Interface.KEY))
  File "/usr/lib/python3.6/site-packages/libnmstate/ifaces/ifaces.py", line 349, in verify
    cur_iface.state_for_verify(),
libnmstate.error.NmstateVerificationError: 
desired
=======
---
name: dummy0
type: dummy
state: up
ovs-db:
  external_ids:
    test: this

current
=======
---
name: dummy0
type: dummy
state: up
ipv4:
  enabled: false
ipv6:
  enabled: false
lldp:
  enabled: false
mac-address: 82:6B:A5:54:F5:A6
mtu: 1500
ovs-db:
  external_ids:
    NM.connection.uuid: 591c40e6-12cb-4c83-8b1e-377bf0840216

difference
==========
--- desired
+++ current
@@ -2,6 +2,14 @@
 name: dummy0
 type: dummy
 state: up
+ipv4:
+  enabled: false
+ipv6:
+  enabled: false
+lldp:
+  enabled: false
+mac-address: 82:6B:A5:54:F5:A6
+mtu: 1500
 ovs-db:
   external_ids:
-    test: this
+    NM.connection.uuid: 591c40e6-12cb-4c83-8b1e-377bf0840216

Comment 4 Mingyu Shi 2021-01-20 12:03:55 UTC
Created attachment 1749056 [details]
beaker.log

Verified with versions:
nmstate-1.0.1-1.el8.noarch
nispor-1.0.1-2.el8.x86_64
NetworkManager-1.30.0-0.5.el8.x86_64

Comment 6 errata-xmlrpc 2021-05-18 15:17:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1748