Bug 1874257

Summary:	Hide cluster upgrade UI on OpenShift Dedicated and Amazon Red Hat OpenShift
Product:	OpenShift Container Platform	Reporter:	Patrick Strick <pstrick>
Component:	Management Console	Assignee:	Robb Hamilton <rhamilto>
Status:	CLOSED ERRATA	QA Contact:	Yanping Zhang <yanpzhan>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.5	CC:	amobrem, aos-bugs, jhadvig, jokerman, pweil, rhamilto, spadgett, yapei
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: The cluster upgrade UI is always present. Consequence: OpenShift Dedicated users are not permitted to perform cluster upgrades. Fix: Hide the cluster upgrade UI when the console branding is OpenShift Dedicated. Result: OpenShift Dedicated users do not see the cluster upgrade UI.	Story Points:	---
Clone Of:
Clones:	1877012 (view as bug list)		Environment:
Last Closed:	2020-10-27 16:36:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1877012

Description Patrick Strick 2020-08-31 20:01:01 UTC

Description of problem:
OSD and AMRO clusters the cluster version is managed through Hive and OpenShift Cluster Manager. In those systesm, no users, including those with the cluster-admin role, should see UI elements about upgrading the cluster in the OpenShift console.

When the cluster is branded as OSD or AMRO:
1. Hide the upgrade notification in the notification drawer, home -> status page, and about dialog
2. Remove the edit channel and start upgrade buttons from the cluster settings page

Version-Release number of selected component (if applicable):
4.5

See https://bugzilla.redhat.com/show_bug.cgi?id=1857843 for a similar change.

Comment 1 Jakub Hadvig 2020-09-01 09:32:29 UTC

Based on the description it should be enough to backport to 4.5.

Comment 6 Robb Hamilton 2020-09-08 17:16:56 UTC

Note https://github.com/openshift/console/pull/6555 only fixes Dedicated as we do not yet have a separate branding option for Amazon Red Hat OpenShift.

Comment 9 Yanping Zhang 2020-09-11 07:49:03 UTC

Checked on 4.6 cluster with payload 4.6.0-0.nightly-2020-09-09-173545.
When brand is ocp, could see upgrade notification from console.
Change brand to dedicated, check on console again, check in the notification drawer, home -> status page, and about dialog, there is no upgrade button link now. Check on cluster settings page, channel edit and update button is hidden.
The bug is fixed.

Comment 11 errata-xmlrpc 2020-10-27 16:36:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196