Bug 1874274

Summary: Review Request: perl-Alien-Build-MB - Alien::Build installer class for Module::Build
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Alien-Build-MB-0.07-1.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-01 13:43:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1874286    

Description Jitka Plesnikova 2020-08-31 21:15:43 UTC 
Spec URL: https://jplesnik.fedorapeople.org/perl-Alien-Build-MB/perl-Alien-Build-MB.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Alien-Build-MB/perl-Alien-Build-MB-0.07-1.fc34.src.rpm

Description:
This is a Module::Build subclass that uses Alien::Build to help create
Alien distributions. The author recommends Alien::Build::MM, which uses
ExtUtils::MakeMaker instead. The primary rationale for this class, is to
prove independence from any particular installer, so that other
installers may be added in the future if they become available. If you
really do prefer to work with Module::Build though, this may be the
installer for you!

Fedora Account System Username: jplesnik
Comment 1 Petr Pisar 2020-09-01 08:00:25 UTC 
URL and Source0 addresses are usable. Ok.
TODO: Remove the trailing slash form the URL value.

Source0 archive (SHA-256: 9a64e5f23a8bc109393aaea5855df7a032eb054d241df2422211e2253d9028a5) is original. Ok.
Summary verified from lib/Alien/Build/MB.pm. Ok.
Description verified from lib/Alien/Build/MB.pm. Ok.
License verified from README, Makefile.PL, LICENSE, and lib/Alien/Build/MB.pm. Ok.

TODO: Constrain 'perl(Alien::Build) with '>= 1.14' (META.json:49).

All tests pass. Ok.

$ rpmlint perl-Alien-Build-MB.spec ../SRPMS/perl-Alien-Build-MB-0.07-1.fc34.src.rpm ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p  ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Sep  1 09:48 /usr/share/doc/perl-Alien-Build-MB
-rw-r--r--    1 root     root                      732 Feb  6  2020 /usr/share/doc/perl-Alien-Build-MB/Changes
-rw-r--r--    1 root     root                     2155 Feb  6  2020 /usr/share/doc/perl-Alien-Build-MB/README
drwxr-xr-x    2 root     root                        0 Sep  1 09:48 /usr/share/licenses/perl-Alien-Build-MB
-rw-r--r--    1 root     root                    18349 Feb  6  2020 /usr/share/licenses/perl-Alien-Build-MB/LICENSE
-rw-r--r--    1 root     root                     2197 Sep  1 09:48 /usr/share/man/man3/Alien::Build::MB.3pm.gz
drwxr-xr-x    2 root     root                        0 Sep  1 09:48 /usr/share/perl5/vendor_perl/Alien
drwxr-xr-x    2 root     root                        0 Sep  1 09:48 /usr/share/perl5/vendor_perl/Alien/Build
-rw-r--r--    1 root     root                     6967 Feb  6  2020 /usr/share/perl5/vendor_perl/Alien/Build/MB.pm
File layout and permissions are Ok.

$ rpm -q --requires -p  ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm |sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(Alien::Build)
      1 perl(base)
      1 perl(Module::Build)
      1 perl(Path::Tiny)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain 'perl(Alien::Build) with '>= 1.14' (META.json:49).

$ rpm -q --provides -p  ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm |sort -f | uniq -c
      1 perl(Alien::Build::MB) = 0.07
      1 perl-Alien-Build-MB = 0.07-1.fc34
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Alien-Build-MB-0.07-1.fc34.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 34 (https://koji.fedoraproject.org/koji/taskinfo?taskID=50543199). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the 'TODO' items before building this package.
Resolution: Package APPROVED.
Comment 2 Gwyn Ciesla 2020-09-01 13:23:13 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Build-MB
Comment 3 Jitka Plesnikova 2020-09-01 13:43:11 UTC 
Thank you for the review and the repository.
Comment 4 Fedora Update System 2020-09-03 07:06:31 UTC 
FEDORA-2020-a63376e93d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a63376e93d
Comment 5 Fedora Update System 2020-09-03 18:09:59 UTC 
FEDORA-2020-a63376e93d has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-a63376e93d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a63376e93d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Fedora Update System 2020-09-25 16:44:06 UTC 
FEDORA-2020-a63376e93d has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.