Bug 1874631

Summary:	Tidy up and improve fix for bug 1755518
Product:	[oVirt] ovirt-engine	Reporter:	Pierre Lecomte <pierre.lecomte>
Component:	BLL.Virt	Assignee:	Pierre Lecomte <pierre.lecomte>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.4.3.1	CC:	ahadas, bugs, lgamliel, nsimsolo, sgratch
Target Milestone:	ovirt-4.4.3	Flags:	pm-rhel: ovirt-4.4+
Target Release:	4.4.3.2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.3.2, OCP-Metal-V1.0.11.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-11 06:41:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pierre Lecomte 2020-09-01 19:07:51 UTC

Description of problem:

The original and current fix :

https://github.com/oVirt/ovirt-engine/commit/da5f6334ac41bb5861ceb1b2b35b5c51e2940c09

for bug 1755518

alters the xml of the .ova generated, making it "less adhering to the xml format definition".

I am submitting with this bug a new fix for the same bug which simplifies the original fix :

- The exported xml adheres to the xml standard for that portion ;
- There is no more any need to alter the template of the xml on import, we only manipulate it on export to make it fit the xml standard.

Version-Release number of selected component (if applicable):

Current

How reproducible:
This is a suggested improvement for an existing fix.

Steps to Reproduce:
See bug 175518 for original steps and fix.

Additional info:
I am submitting this to the ovirt community - I realize the improvement is minor compared to the existing fix, but I still want to propose it instead of just ignoring the community and not proposing y fix, as the fix I am proposing can be viewed as slightly better and simpler than the original one. I hope I am not annoying people submitting this..

Comment 1 RHEL Program Management 2020-09-02 15:04:29 UTC

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 2 Nisim Simsolo 2020-10-11 07:23:39 UTC

Verified:
ovirt-engine-4.4.3.5-0.5.el8ev
vdsm-4.40.32-1.el8ev.x86_64
libvirt-daemon-6.6.0-6.module+el8.3.0+8125+aefcf088.x86_64
qemu-kvm-5.1.0-10.module+el8.3.0+8254+568ca30d.x86_64

Verification scenario:
1. Export RHEL VM as OVA
2. Extract OVA file, observe OVF file and verify characters are within HTML standarts (replace " characters with \\\"  and \n string to their unicode equivalent)
3. Import exported OVA from step 1.
4. Verify import succeeds, run VM and verify VM is running. 
5. Repeat steps 1-4 with Windows VM.

Comment 3 Sandro Bonazzola 2020-11-11 06:41:30 UTC

This bugzilla is included in oVirt 4.4.3 release, published on November 10th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.