Bug 1874754

Description of problem:
Get the error below when runing the CR by using the `helm-operator`:

[root@preserve-olm-env data]# oc logs example-nginx-7df4447d79-jx8dd
2020/09/02 07:05:12 [warn] 1#1: the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
nginx: [warn] the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
2020/09/02 07:05:12 [emerg] 1#1: mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)
nginx: [emerg] mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)

[root@preserve-olm-env data]# oc get pods
NAME                                    READY   STATUS             RESTARTS   AGE
...
example-nginx-7df4447d79-jx8dd          0/1     CrashLoopBackOff   3          70s


Version-Release number of selected component (if applicable):
4.6
Downstream helm-operator

How reproducible:
always

Steps to Reproduce:
1. Init a Helm type nginx-operator by using the `operator-sdk`.
[root@preserve-olm-env nginx-operator]# pwd
/data/goproject/src/github.com/example-inc/nginx-operator
[root@preserve-olm-env nginx-operator]# ls
build  deploy  helm-charts   watches.yaml

2. Compile the downstream helm-operator binary.
[root@preserve-olm-env openshift]# git clone git:openshift/ocp-release-operator-sdk.git
...
[root@preserve-olm-env ocp-release-operator-sdk]# make build/helm-operator
[root@preserve-olm-env ocp-release-operator-sdk]# ls -l ./build/helm-operator 
-rwxr-xr-x. 1 root root 55631400 Sep  2 02:38 ./build/helm-operator

3. Login a OCP 4.6 cluster.
[root@preserve-olm-env nginx-operator]# oc project
Using project "openshift-marketplace" on server "https://api.jiazha0901.qe.devcluster.openshift.com:6443".

4, Deploy the CRD.
[root@preserve-olm-env nginx-operator]# oc create -f deploy/crds/example.com_nginxes_crd.yaml
...
[root@preserve-olm-env nginx-operator]# oc get nginx -A
No resources found

5, Set the "OPERATOR_NAME" value and run this nginx-operator by using the helm-operator.
[root@preserve-olm-env nginx-operator]# export OPERATOR_NAME=nginx-operator
[root@preserve-olm-env nginx-operator]# ./helm-operator run
{"level":"info","ts":1599029881.6350155,"logger":"cmd","msg":"Go Version: go1.14"}
{"level":"info","ts":1599029881.6350768,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1599029881.635086,"logger":"cmd","msg":"Version of operator-sdk: v0.19.0"}
...

6, Deploy a nginx CR.
[root@preserve-olm-env nginx-operator]# oc create -f deploy/crds/example.com_v1alpha1_nginx_cr.yaml
...

Actual results:
The CR created sucecssfully, but its pod is crashing.

[root@preserve-olm-env data]# oc get pods
NAME                                    READY   STATUS             RESTARTS   AGE
...
example-nginx-7df4447d79-jx8dd          0/1     CrashLoopBackOff   3          70s
...

[root@preserve-olm-env data]# oc logs example-nginx-7df4447d79-jx8dd
2020/09/02 07:05:12 [warn] 1#1: the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
nginx: [warn] the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:2
2020/09/02 07:05:12 [emerg] 1#1: mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)
nginx: [emerg] mkdir() "/var/cache/nginx/client_temp" failed (13: Permission denied)


Expected results:
The CR pod should works well.


Additional info:

[root@preserve-olm-env nginx-operator]# ./helm-operator run
{"level":"info","ts":1599029881.6350155,"logger":"cmd","msg":"Go Version: go1.14"}
{"level":"info","ts":1599029881.6350768,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1599029881.635086,"logger":"cmd","msg":"Version of operator-sdk: v0.19.0"}
{"level":"info","ts":1599029881.6379602,"logger":"cmd","msg":"WATCH_NAMESPACE environment variable not set. Watching all namespaces.","Namespace":""}
I0902 02:58:02.765044   20527 request.go:621] Throttling request took 1.027322925s, request: GET:https://api.jiazha0901.qe.devcluster.openshift.com:6443/apis/machine.openshift.io/v1beta1?timeout=32s
{"level":"info","ts":1599029884.0876718,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":"0.0.0.0:8383"}
{"level":"info","ts":1599029884.0884671,"logger":"helm.controller","msg":"Watching resource","apiVersion":"example.com/v1alpha1","kind":"Nginx","namespace":"","reconcilePeriod":"1m0s"}
{"level":"info","ts":1599029884.0885055,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1599029884.0885339,"logger":"leader","msg":"Skipping leader election; not running in a cluster."}
{"level":"info","ts":1599029884.0885646,"logger":"cmd","msg":"Could not generate and serve custom resource metrics","Namespace":"","error":"WATCH_NAMESPACE must be set"}
{"level":"info","ts":1599029886.5114994,"logger":"metrics","msg":"Skipping metrics Service creation; not running in a cluster."}
{"level":"info","ts":1599029888.932723,"logger":"controller-runtime.manager","msg":"starting metrics server","path":"/metrics"}
{"level":"info","ts":1599029888.9327874,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nginx-controller","source":"kind source: example.com/v1alpha1, Kind=Nginx"}
{"level":"info","ts":1599029889.0333405,"logger":"controller-runtime.controller","msg":"Starting Controller","controller":"nginx-controller"}
{"level":"info","ts":1599029889.0334074,"logger":"controller-runtime.controller","msg":"Starting workers","controller":"nginx-controller","worker count":1}



I0902 02:58:35.292883   20527 request.go:621] Throttling request took 1.038226606s, request: GET:https://api.jiazha0901.qe.devcluster.openshift.com:6443/apis/operators.coreos.com/v1alpha1?timeout=32s
{"level":"info","ts":1599029917.2595756,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nginx-controller","source":"kind source: /v1, Kind=ServiceAccount"}
{"level":"info","ts":1599029917.3603249,"logger":"helm.controller","msg":"Watching dependent resource","ownerApiVersion":"example.com/v1alpha1","ownerKind":"Nginx","apiVersion":"v1","kind":"ServiceAccount"}
{"level":"info","ts":1599029917.3608084,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nginx-controller","source":"kind source: /v1, Kind=Service"}
{"level":"info","ts":1599029917.4613502,"logger":"helm.controller","msg":"Watching dependent resource","ownerApiVersion":"example.com/v1alpha1","ownerKind":"Nginx","apiVersion":"v1","kind":"Service"}
{"level":"info","ts":1599029917.4620032,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"nginx-controller","source":"kind source: apps/v1, Kind=Deployment"}
{"level":"info","ts":1599029917.5623562,"logger":"helm.controller","msg":"Watching dependent resource","ownerApiVersion":"example.com/v1alpha1","ownerKind":"Nginx","apiVersion":"apps/v1","kind":"Deployment"}
{"level":"info","ts":1599029917.562435,"logger":"helm.controller","msg":"Installed release","namespace":"openshift-marketplace","name":"example-nginx","apiVersion":"example.com/v1alpha1","kind":"Nginx","release":"example-nginx"}
+---
+# Source: nginx/templates/serviceaccount.yaml
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: example-nginx
+  labels:
+    helm.sh/chart: nginx-0.1.0
+    app.kubernetes.io/name: nginx
+    app.kubernetes.io/instance: example-nginx
+    app.kubernetes.io/version: "1.16.0"
+    app.kubernetes.io/managed-by: Helm
+---
+# Source: nginx/templates/service.yaml
+apiVersion: v1
+kind: Service
+metadata:
+  name: example-nginx
+  labels:
+    helm.sh/chart: nginx-0.1.0
+    app.kubernetes.io/name: nginx
+    app.kubernetes.io/instance: example-nginx
+    app.kubernetes.io/version: "1.16.0"
+    app.kubernetes.io/managed-by: Helm
+spec:
+  type: ClusterIP
+  ports:
+    - port: 80
+      targetPort: http
+      protocol: TCP
+      name: http
+  selector:
+    app.kubernetes.io/name: nginx
+    app.kubernetes.io/instance: example-nginx
+---
+# Source: nginx/templates/deployment.yaml
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: example-nginx
+  labels:
+    helm.sh/chart: nginx-0.1.0
+    app.kubernetes.io/name: nginx
+    app.kubernetes.io/instance: example-nginx
+    app.kubernetes.io/version: "1.16.0"
+    app.kubernetes.io/managed-by: Helm
+spec:
+  replicas: 1
+  selector:
+    matchLabels:
+      app.kubernetes.io/name: nginx
+      app.kubernetes.io/instance: example-nginx
+  template:
+    metadata:
+      labels:
+        app.kubernetes.io/name: nginx
+        app.kubernetes.io/instance: example-nginx
+    spec:
+      serviceAccountName: example-nginx
+      securityContext:
+        {}
+      containers:
+        - name: nginx
+          securityContext:
+            {}
+          image: "nginx:1.16.0"
+          imagePullPolicy: IfNotPresent
+          ports:
+            - name: http
+              containerPort: 80
+              protocol: TCP
+          livenessProbe:
+            httpGet:
+              path: /
+              port: http
+          readinessProbe:
+            httpGet:
+              path: /
+              port: http
+          resources:
+            {}

{"level":"info","ts":1599029920.6204355,"logger":"helm.controller","msg":"Reconciled release","namespace":"openshift-marketplace","name":"example-nginx","apiVersion":"example.com/v1alpha1","kind":"Nginx","release":"example-nginx"}