Bug 1874921

Summary:	[RFE] Service Retirement Logging improvement to show Service id
Product:	Red Hat CloudForms Management Engine	Reporter:	Tina Fitzgerald <tfitzger>
Component:	Appliance	Assignee:	drew uhlmann <duhlmann>
Status:	CLOSED ERRATA	QA Contact:	Tasos Papaioannou <tpapaioa>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.11.5	CC:	dmetzger, mshriver, obarenbo, simaishi, yrudman
Target Milestone:	GA	Keywords:	FutureFeature, ZStream
Target Release:	5.11.8	Flags:	simaishi: cfme-5.11.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.8.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-30 14:04:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Feature
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Tina Fitzgerald 2020-09-02 15:06:53 UTC

RFE opened as a result of an investigation: 
https://github.com/ManageIQ/manageiq/issues/20503

We support duplicate names in our Service objects, and Service id's are not included in the retirement log messages.  Adding the Service id's to the log message will help with debugging efforts.  


Steps to Reproduce:
1. Create/order/retire Service.
2. Search logs for retirement messages to see the id's are not included.

Comment 2 Dave Johnson 2020-09-02 16:04:56 UTC

Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 3 Tina Fitzgerald 2020-09-02 17:19:04 UTC

Drew created a PR to resolve the issue: https://github.com/ManageIQ/manageiq/pull/20507

Thanks Drew. :-)

Comment 5 CFME Bot 2020-09-04 19:25:23 UTC

New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/adeb5ddcea68ac8ea4307fc1397d010b1d9c4ba1
commit adeb5ddcea68ac8ea4307fc1397d010b1d9c4ba1
Author:     Keenan Brock <keenan>
AuthorDate: Tue Sep  1 14:49:31 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Fri Sep  4 19:18:46 2020 +0000

    Merge pull request #20507 from d-m-u/enhancing_retirement_logging

    add ids to the retirement log lines

    (cherry picked from commit ef70975ea5b2f40c8f135571ea6ce158aaa873e0)

    https://bugzilla.redhat.com/show_bug.cgi?id=1874921

 app/models/mixins/retirement_mixin.rb | 28 +-
 spec/models/orchestration_stack/retirement_management_spec.rb | 2 +-
 spec/models/service/retirement_management_spec.rb | 2 +-
 spec/models/vm/retirement_management_spec.rb | 2 +-
 4 files changed, 17 insertions(+), 17 deletions(-)

Comment 6 Tasos Papaioannou 2020-09-10 16:08:22 UTC

Verified on 5.11.8.0.

Comment 11 errata-xmlrpc 2020-09-30 14:04:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: CloudForms 5.0.8 security, bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:4134