Bug 187622
| Summary: | Review Request: cowbell | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sindre Pedersen Bjørdal <sindrepb> | ||||
| Component: | Package Review | Assignee: | Brian Pepple <bdpepple> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-05-16 13:32:06 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Sindre Pedersen Bjørdal
2006-04-01 23:35:33 UTC
Build failed on x86_64.
File not found: /var/tmp/cowbell-0.2.6.1-1-root-mockbuild/usr/lib64/cowbell
Apparently mono apps install to %{_prefix}/lib.
http://fedoraproject.org/wiki/Packaging/Mono
Need more cowbell!!!
replaced %{_libdir} with %{_prefix}/lib/
hope this will fix x86_64 build issue.
Updated spec: http://folk.ntnu.no/sindrb/packages/cowbell.spec
SRPM: http://folk.ntnu.no/sindrb/packages/cowbell-0.2.6.1-2.src.rpm
Builds now, but for some reason I cannot add anything to the database. Possibly the latest 0.2.7 release fixes it. 0.2.7 builds but crashes when music is imported. Traced the problem to cowbell looking for libglib-2.0.so but on my system it is libglib-2.0.so.0 Symlinking it works, perhaps cowbell can be made to look there or glib2 made to provide a link. Created attachment 128528 [details]
spec patch
Fairly trivial, bumps version to 0.2.7. Doesn't split of a devel subpackage,
which may be necessary.
Updated spec: http://folk.ntnu.no/sindrb/packages/cowbell.spec Updated SRPM: http://folk.ntnu.no/sindrb/packages/cowbell-0.2.7-1.src.rpm Does this build and run cleanly on x86_64 now? It should look for libglib-2.0.so.0 (not libglib-2.0.so which belongs into the glib2-devel package). This has been pushed upstream, new release imminent. I'll update the spec accordingly as soon as the new release is out. New release is out, this should fix the glib dependency. Updated spec: http://folk.ntnu.no/sindrb/packages/cowbell.spec SRPM: http://folk.ntnu.no/sindrb/packages/cowbell-0.2.7.1-1.src.rpm MD5Sums:
fcf32bcf60be2ca204519192eb26bacc cowbell-0.2.7.1.tar.gz
Good:
* Source URL is canonical
* Upstream source tarball verified
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Package installs and uninstalls cleanly on FC5
Bad:
* Missing scriptlets for GTK+ icon cache.
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
* Missing Requires for mono-core & gtk-sharp2
Minor:
* Why package the static lib? Pass the --disable-static flag to configure, and
remove '%{_libdir}/cowbell/libtaglibsharpglue.a' from your files.
* Unnecessary BR on gettext. This is included in the minimum build environment
in Mock.
* I would drop the ChangeLog from the docs, since the NEWS file basically
contains the same info.
Updated spec: http://folk.ntnu.no/sindrb/packages/cowbell.spec SRPM: http://folk.ntnu.no/sindrb/packages/cowbell-0.2.7.1-2.src.rpm Changes: - Add missing mono-core and gtk-sharp2 Requires - Add scriplets for gtk+ icon cache - Removed ChangeLog from %doc - Don't include static library - Remove gettext BuildRequires Changes in response to the review in comment #10 look good. * rpmlint is clean. +1 PUBLISH |