Bug 187625
| Summary: | Review Request: ices IceS is a source client for a streaming server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard June <rjune> |
| Component: | Package Review | Assignee: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-27 21:09:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard June
2006-04-02 00:52:16 UTC
- Release should start at 1
- Summary should not contain the app name
- Drop / before %{_localstatedir} and %{_sysconfdir}
- Need to own %{_datadir}/%{name}
- Don't be afraid to use %{name} and %{version} where appropriate
Fixed all of those. ices-2.0.1-2.src.rpm: http://home.bravegnuworld.com/~rjune/rpm/SRPMS/ices-2.0.1-2.src.rpm - First word of summary should be capitalized
- Drop %{_datadir}/ices/* from %files as the previous line covers it
- Put one newline between chnagelog entries
Fixed all of those. ices-2.0.1-3.src.rpm: http://home.bravegnuworld.com/~rjune/rpm/SRPMS/ices-2.0.1-3.src.rpm Almost there.
W: ices conffile-without-noreplace-flag /etc/logrotate.d/ices
Also a number of build warnings I don't like, but I wont't consider them
blockers. Kick them upstream.
Also, I can't help but think that most of the items in %{_datadir}/ices might be
better off all being in %doc instead.
Fixed the conffile without noreplace flag ices-2.0.1-4.src.rpm: http://home.bravegnuworld.com/~rjune/rpm/SRPMS/ices-2.0.1-4.src.rpm Moved HTML files to %doc ices-2.0.1-5.src.rpm: http://home.bravegnuworld.com/~rjune/rpm/SRPMS/ices-2.0.1-5.src.rpm The HTML and CSS files have been moved, but the XML files are now MIA. Also, the
XML files should probably be marked %config(noreplace) and relocated to
%{_sysconfdir}/%{name}.
So it turns out that someone had already submitted ices for review. Silly me for not noticing. |