Bug 1877919
| Summary: | panic in multus-admission-controller | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | David Eads <deads> |
| Component: | Networking | Assignee: | Douglas Smith <dosmith> |
| Networking sub component: | multus | QA Contact: | Weibin Liang <weliang> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | high | ||
| Priority: | high | CC: | dosmith, mnewby |
| Version: | 4.6 | ||
| Target Milestone: | --- | ||
| Target Release: | 4.7.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | No Doc Update | |
| Doc Text: |
(this couldn't be replicated)
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-24 15:17:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
*** Bug 1877208 has been marked as a duplicate of this bug. *** PR https://github.com/openshift/network-metrics-daemon/pull/26 should be merged 11 days ago, but I still see openshift-multus_multus-admission-controller panic about 8 hours ago in https://search.ci.openshift.org/?search=interface+conversion%3A+cache.DeletedFinalStateUnknown+is+not+v1.Object&maxAge=48h&context=1&type=bug%2Bjunit&name=&maxMatches=5&maxBytes=20971520&groupBy=job, This is easy to fix, so why not fix it ASAP for 4.6? Leaving unexpected panics latent in the code inures engineers to seeing these errors in their CI results, which can only hurt us. We have the proposed fix merged in https://bugzilla.redhat.com/show_bug.cgi?id=1877919 and while this makes sense to me, I'm unsure how to diagnose why this hasn't fixed in according to the link from Weibin. My current step is to check that the build of the multus-admission-controller indeed has this code, which I'm in the process of doing. Agreed that it would be much better to have in 4.6. Correction: merged in https://github.com/openshift/multus-admission-controller/pull/27 Try limiting the search to 4.6 jobs: https://search.ci.openshift.org/?search=interface+conversion%3A+cache.DeletedFinalStateUnknown+is+not+v1.Object&maxAge=48h&context=1&type=bug%2Bjunit&name=4.6&maxMatches=5&maxBytes=20971520&groupBy=job I don't see anything recent. Do not see any more multus panic log shown in v4.6 job Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:5633 |
pods/openshift-multus_multus-admission-controller-dlnrf_multus-admission-controller_previous.log.gz:E0910 10:19:45.911352 1 runtime.go:73] Observed a panic: &runtime.TypeAssertionError{_interface:(*runtime._type)(nil), concrete:(*runtime._type)(0x1175e80), asserted:(*runtime._type)(0x1225320), missingMethod:"GetAnnotations"} (interface conversion: cache.DeletedFinalStateUnknown is not v1.Object: missing method GetAnnotations) E0910 10:19:45.911352 1 runtime.go:73] Observed a panic: &runtime.TypeAssertionError{_interface:(*runtime._type)(nil), concrete:(*runtime._type)(0x1175e80), asserted:(*runtime._type)(0x1225320), missingMethod:"GetAnnotations"} (interface conversion: cache.DeletedFinalStateUnknown is not v1.Object: missing method GetAnnotations) goroutine 85 [running]: github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1131d60, 0xc000593590) /go/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/gopath/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:69 +0x7b github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0) /go/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/gopath/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51 +0x82 panic(0x1131d60, 0xc000593590) /usr/lib/golang/src/runtime/panic.go:969 +0x166 github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/pkg/controller.newResourceController.func3(0x1175e80, 0xc000111bc0) /go/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/gopath/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/pkg/controller/controller.go:155 +0x57 github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/client-go/tools/cache.ResourceEventHandlerFuncs.OnDelete(...) /go/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/gopath/src/github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/client-go/tools/cache/controller.go:209 github.com/k8snetworkplumbingwg/net-attach-def-admission-controller/vendor/k8s.io/client-go/tools/cache.(*processorListener).run.func1.1(0x0, 0x0, 0x0)