Bug 1877978
| Summary: | %pyproject_buildrequires -x does not work when used repeatedly | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | pyproject-rpm-macros | Assignee: | Miro Hrončok <mhroncok> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fschwarz, mhroncok, pviktori, python-sig |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | pyproject-rpm-macros-0-30.fc34 pyproject-rpm-macros-0-30.fc33 pyproject-rpm-macros-0-30.fc32 pyproject-rpm-macros-0-30.fc31 pyproject-rpm-macros-0-37.eln109 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-10-01 15:59:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The reasoning for `-x test,full` is that the PEP 508 syntax (used in `pip install`, `setup.py`, etc) is `...[test,full]`. So, I think the comma-separated list is still useful, in addition to multiple options. OK, let's keep support for both. FEDORA-2020-6b747c26e1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6b747c26e1 FEDORA-2020-20741bd099 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-20741bd099 FEDORA-2020-7d84d3ea99 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d84d3ea99 FEDORA-2020-7b01d713e7 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-20741bd099 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-20741bd099` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-20741bd099 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-6b747c26e1 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6b747c26e1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6b747c26e1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-7d84d3ea99 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-7d84d3ea99` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d84d3ea99 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-20741bd099 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-7d84d3ea99 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-6b747c26e1 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-46d1d95820 has been pushed to the Fedora ELN stable repository. If problem still persists, please make note of it in this bug report. |
The -x option for %pyproject_buildrequires currently supports multiple comma-separated extras: %pyproject_buildrequires -x test,full It is possible to repeat options when invoking RPM macros, so this seems like a more natural way of doing it: %pyproject_buildrequires -x test -x full The argument parser in pyproject_buildrequires.py currently trows away all but the last -x values. This can be fixed by something like: parser.add_argument( '-x', ..., action='append', ... ) I'd even argue that the comma-separated way of doing this should be replaced by the multiple options approach only.