Bug 1878070

Summary: Flatpak update shows weird progress
Product: Red Hat Enterprise Linux 8 Reporter: Petr Nehez <petr>
Component: flatpakAssignee: Debarshi Ray <debarshir>
Status: CLOSED DUPLICATE QA Contact: Desktop QE <desktop-qa-list>
Severity: low Docs Contact:
Priority: unspecified    
Version: 8.2CC: dking, klember, mkrajnak, petr, tpelka, tpopela
Target Milestone: rc   
Target Release: 8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-02-09 11:48:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1851958    
Bug Blocks:    
Attachments:
Description Flags
Screenshot of `flatpak update` none

Description Petr Nehez 2020-09-11 09:08:12 UTC
Created attachment 1714533 [details]
Screenshot of `flatpak update`

Description of problem:
When invoking a command `flatpak update` I get quite often a weird progressbar which goes highly above 100% (image attached).


Version-Release number of selected component (if applicable):
Flatpak 1.6.2

How reproducible:
The weird behavior does not occur for all update items, I have not found out any pattern in it.

Additional info:
What I remember this issue was not happening in 1.0.x version.

Comment 1 Tomas Popela 2020-09-14 08:16:37 UTC
Note: This linked PR is for ostree based Flatpaks (ie. Flathub ones). The OCI Flatpaks (RHEL, Fedora) had the progress broken as well and it was fixed with https://github.com/flatpak/flatpak/pull/3850

Comment 2 Kalev Lember 2020-09-14 08:34:29 UTC
https://github.com/flatpak/flatpak/pull/3850 fixed OCI progress not working at all in flatpak 1.8.x (it had regressed compared to 1.6.x). I don't think it changed anything related to the 100% issue.

Comment 3 Tomas Popela 2020-09-14 08:51:29 UTC
True, I just wanted to mention the OCI issue there as well so when the 1.8 rebase will be tested we check both OCI and ostree (as the OCI change wasn't backported to 1.8 - it might be in some of the future 1.8.x release)

Comment 6 Debarshi Ray 2022-02-09 11:08:56 UTC
(In reply to Tomas Popela from comment #3)
> True, I just wanted to mention the OCI issue there as well so when the 1.8
> rebase will be tested we check both OCI and ostree (as the OCI change wasn't
> backported to 1.8 - it might be in some of the future 1.8.x release)

https://github.com/flatpak/flatpak/pull/3850 was backported to flatpak-1.8.3:
https://github.com/flatpak/flatpak/commit/4e47dba3b3ae095abd0cb2d53ec99c1d68d0d4b7

It has been in RHEL 8 since 8.4.

Maybe Martin knows if we have tests for it - do we?  It would be ideal if the upstream test suite covered this.  I don't know if it does.

Comment 7 Debarshi Ray 2022-02-09 11:17:28 UTC
The original issue that was reported here (ie., https://github.com/flatpak/flatpak/issues/3448) was fixed in flatpak-1.7.2:
https://github.com/flatpak/flatpak/commit/c3616ab1ebb30b6fe4fb6d534881521079bb826c
https://github.com/flatpak/flatpak/commit/e2c8838cea2837111c3016cbdd7e04bda3de638b

This was pulled into RHEL 8 as part of the rebase from 1.6.x to 1.8.x in 8.4 (bug 1851958).

Again, it's not clear to me if we have tests for this or not.

Comment 8 Debarshi Ray 2022-02-09 11:48:27 UTC
I am marking this as a duplicate of the rebase to 1.8.x

I am still curious about the tests, though.  If we don't have anything, I can look into adding some to the upstream test suite.

*** This bug has been marked as a duplicate of bug 1851958 ***