Bug 1878879
Summary: | [RFE] Maintain/Enable custom reports through Satellite patching/upgrade | ||
---|---|---|---|
Product: | Red Hat Satellite | Reporter: | patalber |
Component: | Reporting | Assignee: | satellite6-bugs <satellite6-bugs> |
Status: | CLOSED NOTABUG | QA Contact: | Lukáš Hellebrandt <lhellebr> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 6.7.0 | CC: | daniel.shaver, dmatoule, mhulan, oprazak |
Target Milestone: | Unspecified | Keywords: | FutureFeature |
Target Release: | Unused | Flags: | patalber:
needinfo-
|
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-10-01 07:09:10 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
patalber
2020-09-14 18:25:58 UTC
I am sorry, after reading the request for several times, I still don't understand, what is the expected outcome. If I understand correctly, customer cloned and modified the default template and after update would like to apply same changes we apply to the default template to their clone? I'm not sure how we could achieve that. Some customers may not want their clones to be touched at all. Also some changes may cause conflicts with custom changes. So I'd like to better understand the expectation here. Marek, I have passed along the request to the customer and am awaiting their response. Thank you. --Patrick The intent of the request is not to modify canned reports, but to have upgrades to Satellite not break custom reports. This is in reference to RH Case 02740721, where in order to get "custom" fields available within a report, /usr/share/foreman/lib/foreman/renderer/scope/macros/base.rb needed to be edited and safe mode for template rendering needed to be disabled. The request is that these changes be preserved or at least a warning/notification when the application is upgraded. There's no way to avoid this. If customer modifies the source code, customer changes are overriden on ugprade. Modifying a source code is not supported, the correct flow is to raise RFE to add new macros and we ship them in next Satellite version or in urgent cases, we can build a hotfix. When support suggests to modify the source code, the new version of Satellite will override any customization. If I understand the case correctly, I'd suggest closing this as not a bug. A week without reply from the reporter has passed, closing as suggested in previous comment. Please reopen if I missed something, but as stated above, changing the source code to add new macros can't be really supported on upgrades, we need to upgrade the source code during upgrade process. A separate RFE was opened to add the module to base. Apologies for not updating. |