Bug 1879475

Summary:	Operator condition reasons should be unique
Product:	OpenShift Container Platform	Reporter:	Jan Safranek <jsafrane>
Component:	Storage	Assignee:	Christian Huffman <chuffman>
Storage sub component:	Operators	QA Contact:	Qin Ping <piqin>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, inecas
Version:	4.6
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:41:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Safranek 2020-09-16 11:27:12 UTC

Description of problem:

Found by Insights team when analyzing 4.3 -> 4.4 upgrades and noticing csi-snapshot-controller-operator stuck at "Waiting for Deployment to deploy csi-snapshot-controller pods". Telemetry does not gather condition messages, they collect only Reason. And in this case, the reason was AsExpected, which is hard to filter with - this Reason is used in too many other cases.

Each failure condition should have its own Reason. We should audit AsExpected occurrence in all storage operators:

- cluster-csi-snapshot-controller-operator
- cluster-storage-operator
- CSI driver operators

For example:
https://github.com/openshift/cluster-storage-operator/pull/63/files#diff-97e82b0d41902abcb7a788ea37573993R328
https://github.com/openshift/cluster-csi-snapshot-controller-operator/blob/108649ce8d46991803eef8fa43f25f112f41addb/pkg/operator/sync.go#L199

Comment 4 Christian Huffman 2020-09-29 15:29:48 UTC

Submitted the following PRs to update the CSI drivers:

- https://github.com/openshift/aws-ebs-csi-driver-operator/pull/95
- https://github.com/openshift/csi-driver-manila-operator/pull/66
- https://github.com/openshift/openstack-cinder-csi-driver-operator/pull/5

Comment 6 Qin Ping 2020-09-30 08:35:19 UTC

In 4.6.0-0.nightly-2020-09-29-215452, all the PRs are included, marked this bug as verified.

Comment 9 errata-xmlrpc 2020-10-27 16:41:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196