Bug 1879583

Summary:	Unclear error message when installation fails due to wrong pull secret
Product:	OpenShift Container Platform	Reporter:	Udi Kalifon <ukalifon>
Component:	assisted-installer	Assignee:	Michael Filanov <mfilanov>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	aos-bugs, iovadia, mfilanov
Version:	4.6
Target Milestone:	---
Target Release:	4.6.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-25 13:49:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Udi Kalifon 2020-09-16 14:49:29 UTC

Description of problem:
I corrupted the pull secret when I created the cluster, by adding random characters to the different blobs in it. Installation failed with:

Cluster installation failed
Generating kubeconfig files ignition-generator-140df53a-0faa-4083-8a96-ca80f43b9305-1600257 failed for cluster 140df53a-0faa-4083-8a96-ca80f43b9305: job <ignition-generator-140df53a-0faa-4083-8a96-ca80f43b9305-1600257> failed <3> times.
Reset the installation process to return to the configuration and try again. Some hosts may need to be re-registered by rebooting into the Discovery ISO.

When I clicked on "Download Installation Logs" I got:
Could not download cluster installation logs.
No log files were found


Version-Release number of selected component (if applicable):
Staging environment from Sep. 16


How reproducible:
100%


Steps to Reproduce:
1. Create a new cluster and change the pull secret so it's not valid, for example by adding random characters to the different blobs
2. Run a cluster installation


Actual results:
The error message is uninformative


Expected results:
More details on what went wrong, so it'll be easy to figure out that the pull secret is not right

Comment 1 Michael Filanov 2020-09-17 08:15:21 UTC

We already have a wiremock defined so pull secret can probably be validated when defined.

Comment 2 Michael Filanov 2020-09-17 08:16:50 UTC

https://github.com/openshift/assisted-service/blob/master/internal/cluster/validations/validations.go#L123-L141

Comment 3 Michael Filanov 2020-09-17 08:43:35 UTC

Duplication with https://issues.redhat.com/browse/MGMT-2137

Comment 4 Ido Ovadia 2020-09-21 13:32:45 UTC

Verified
========
Staging v1.0.9.4

Comment 7 errata-xmlrpc 2021-08-25 13:49:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6.43 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3197