Bug 1879907

Summary: Add storage capabilities report for CSI certification tests
Product: OpenShift Container Platform Reporter: Arnon Gilboa <agilboa>
Component: Test InfrastructureAssignee: Arnon Gilboa <agilboa>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.6CC: yadu
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-27 16:41:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Arnon Gilboa 2020-09-17 10:34:16 UTC
We would like to add storage capabilities report following the CSI certification tests, as discussed in the attached github PR.

E.g.:

$ podman run -v `pwd`:/data:z --rm -it $CONTAINER sh -c "KUBECONFIG=/data/kubeconfig.yaml TEST_CSI_DRIVER_FILES=/data/manifest.yaml /usr/bin/openshift-tests run openshift/csi --junit-dir /data/results"

openshift-tests version: v4.1.0-3107-g627d022
…
Writing JUnit report to /data/results/junit_e2e_20200907-091404.xml

32 pass, 146 skip (4m35s)

Storage Capabilities (guaranteed only on full CSI test suite with 0 fails)
==========================================================================
Driver short name:                  ceph-test
Driver name:                        test.rbd.csi.ceph.com
Storage class:                      ceph-rbd-sc.yaml
Raw block VM disks supported:       true
Live migration supported:           false
VM snapshots supported:             false
Storage-assisted cloning supported: false

Comment 2 Yan Du 2020-09-21 08:50:28 UTC
Test with latest OCP4.6 test image
Version:  4.6.0-0.nightly-2020-09-21-030155

Writing JUnit report to /data/results/junit_e2e_20200921-083944.xml

43 pass, 135 skip (4m57s)

Storage Capabilities (guaranteed only on full CSI test suite with 0 fails)
==========================================================================
Driver short name:                  ceph-test
Driver name:                        openshift-storage.rbd.csi.ceph.com
Storage class:                      ceph-rbd-sc.yaml
Raw block VM disks supported:       true
Live migration supported:           false
VM snapshots supported:             true
Storage-assisted cloning supported: true

Comment 3 Yan Du 2020-09-21 12:33:29 UTC
when set FromFile in manifest.yaml
```
SnapshotClass:
  # Must be set to enable snapshotting tests
  FromFile: /data/snapshotclass.yaml
  ...
 
  # Support populate data from snapshot
  snapshotDataSource: true

```

The Storage report shows false for VM snapshot supported and Storage-assisted cloning supported
Storage Capabilities (guaranteed only on full CSI test suite with 0 fails)
==========================================================================
Driver short name:                  ceph-test
Driver name:                        openshift-storage.rbd.csi.ceph.com
Storage class:                      ceph-rbd-sc.yaml
Raw block VM disks supported:       true
Live migration supported:           false
VM snapshots supported:             false
Storage-assisted cloning supported: false

Discussed with Arnon, the storage report need a minor change, move back to Assigned

Comment 4 Arnon Gilboa 2020-09-21 13:21:35 UTC
@yadu I'll fix it once I get a clarification from Fábio Bertinatto

Comment 5 Jan Safranek 2020-09-21 13:26:28 UTC
The new output is wrong. It mixes CSI features and CNV features. Please distinguish them clearly.

Expected result:

Driver short name:                  ceph-test
Driver name:                        openshift-storage.rbd.csi.ceph.com
Storage class:                      ceph-rbd-sc.yaml
Supported CSI features:
 Raw block:                         true
 Snapshots:                         true
 Cloning:                           true
 Resize:                            false
 ...


Supported CNV features:
  Raw block VM disks:               true
  Live migration:                   false
  VM snapshots:                     false
  Storage-assisted cloning:         false
  ...

Comment 6 Arnon Gilboa 2020-09-21 13:40:23 UTC
@jsafrane, good idea, thanks!

Comment 7 Arnon Gilboa 2020-09-21 14:35:43 UTC
*** Bug 1879903 has been marked as a duplicate of this bug. ***

Comment 9 Yan Du 2020-09-29 06:34:11 UTC
Test on latest OCP4.6 test image, issue have been fixed.

Storage Capabilities (guaranteed only on full CSI test suite with 0 fails)
==========================================================================
Driver short name:                         ceph-test
Driver name:                               openshift-storage.rbd.csi.ceph.com
Storage class:                             ceph-rbd-sc.yaml
Supported OpenShift / CSI features:
  Persistent volumes:                      true
  Raw block mode:                          true
  FSGroup:                                 false
  Executable files on a volume:            true
  Volume snapshots:                        true
  Volume cloning:                          false
  Use volume from multiple pods on a node: false
  ReadWriteMany access mode:               true
  Volume expansion for controller:         false
  Volume expansion for node:               false
  Volume limits:                           false
  Volume can run on single node:           false
  Topology:                                false
Supported CNV features:
  Raw block VM disks:                      true
  Live migration:                          true
  VM snapshots:                            true
  Storage-assisted cloning:                true

Comment 12 errata-xmlrpc 2020-10-27 16:41:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196