Bug 1880424

Summary: [RFE] VM Disk stats should contain IOPS stats
Product: [oVirt] ovirt-engine Reporter: Jean-Louis Dupond <jean-louis>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Evelina Shames <eshames>
Severity: low Docs Contact:
Priority: high    
Version: 4.4.1CC: ahadas, bugs, jean-louis, michal.skrivanek, mperina, pelauter, sbonazzo, sfishbai, sradco, tnisan, vjuranek
Target Milestone: ovirt-4.4.4Keywords: FutureFeature
Target Release: 4.4.3.8Flags: pm-rhel: ovirt-4.4+
pelauter: planning_ack+
sbonazzo: devel_ack+
lleistne: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.3.8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1887149 (view as bug list) Environment:
Last Closed: 2020-12-21 12:35:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1887149    
Attachments:
Description Flags
Possible patch
none
Now with upgrade db script added none

Description Jean-Louis Dupond 2020-09-18 13:49:58 UTC 
Currently the DWH contains read/write stats for each VM:

v4_4_statistics_vms_disks_resources_usage_samples contains:
read_rate_bytes_per_second | read_latency_seconds | write_rate_bytes_per_second | write_latency_seconds | flush_latency_seconds

It would be nice if this could be extended with read and write IOPS stats.

As far as I can see VDSM already reads those stats, but they are never parsed/saved in the ovirt-engine.

I think IOPS stats are equally important as read/write byte stats, as it could be you have huge amount of IOPS on a VM, but low troughput.
So without IOPS stats you cannot notice this.
Comment 1 Jean-Louis Dupond 2020-09-18 14:52:18 UTC 
Created attachment 1715392 [details]
Possible patch

attached a possible patch.
Might have forgotten things, but should be quite ok :)
Comment 2 Jean-Louis Dupond 2020-09-18 14:59:41 UTC 
Created attachment 1715393 [details]
Now with upgrade db script added
Comment 3 Sandro Bonazzola 2020-09-18 15:07:12 UTC 
Shirly can you please review?
Comment 4 RHEL Program Management 2020-09-18 15:07:16 UTC 
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.
Comment 5 RHEL Program Management 2020-09-18 15:08:00 UTC 
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.
Comment 6 Michal Skrivanek 2020-09-21 08:46:26 UTC 
can you please push(and follow on) the patch to gerrit.ovirt.org?
Comment 9 Sandro Bonazzola 2020-11-06 13:54:18 UTC 
$ git tag --contains 583dce8ab676eba10b1fb58b4d28d11cfa7bb22d
ovirt-engine-4.4.3.10
ovirt-engine-4.4.3.8
ovirt-engine-4.4.3.9

This can be tested with 4.4.3 build
Comment 10 Evelina Shames 2020-12-02 16:26:18 UTC 
Verified on ovirt-engine-4.4.4.2-0.1.el8ev.noarch with the following steps:

1. Create a VM with disk and OS
2. Run the VM
3. Perform cp to a big file and in parallel check that read_ops and write_ops values are changing in the DB:
   # engine-psql.sh -c "SELECT image_id, read_ops, write_ops from disk_image_dynamic"

Moving to 'Verified'.
Comment 11 Sandro Bonazzola 2020-12-21 12:35:58 UTC 
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.