Bug 1880738

Summary:	origin e2e test deletes original worker
Product:	OpenShift Container Platform	Reporter:	Michael Gugino <mgugino>
Component:	Cloud Compute	Assignee:	Joel Speed <jspeed>
Cloud Compute sub component:	Other Providers	QA Contact:	Milind Yadav <miyadav>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	low	CC:	eparis, mfedosin, mimccune
Version:	4.6
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-12 04:34:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Gugino 2020-09-19 14:51:34 UTC

https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-vsphere-serial/1307118468956426240

origin e2e tests have a small amount of tests around the machine-api.  Just scale up one machine, then scale down, make sure that machine joined the cluster.  This runs towards the end of the tests so as to not disrupt other tests.

Unlike our more comprehensive e2e tests for our own repos, this test does not create a new machineset.  Default machineset options cause us to delete a random machine on scale down, which is probably not what we want.

We should use the annotation to specify which machine we want to remove on scale down to be least disruptive.

Comment 1 Michael Gugino 2020-09-19 14:52:18 UTC

Talking about this tests specifically: https://github.com/openshift/origin/blob/f749b790af49f66b558b04f4ffd2799dd4a1e165/test/extended/machines/scale.go#L121

Comment 3 Joel Speed 2020-09-30 11:19:06 UTC

@MGugino are you happy to handle this during the next sprint? This definitely isn't a release blocker but is high priority as it affects testing across many components

Do you think it best to annotate the machine to be removed or should we instead create a new MachineSet for this test?

Comment 4 Michael Gugino 2020-10-06 15:02:18 UTC

We intend to refactor these tests generally by making our specific tests 'steps' that other test suites can run limited parts of.  We are planning on doing that in the near future.

Comment 5 Joel Speed 2020-11-13 14:14:09 UTC

A recent change to the test configuration (migrating everything to steps) means that this is now unblocked, we can take a look at this next sprint

Comment 6 Michael McCune 2020-12-04 21:33:17 UTC

the PRs associated with this issue are under review

Comment 7 Joel Speed 2021-01-19 16:11:04 UTC

This isn't really considered an urgent issue, we are looking into solving this issue but it will take a longer time to come up with a good solution for this

Comment 16 Milind Yadav 2021-12-20 03:35:53 UTC

Using the test-grid - https://testgrid.k8s.io/redhat-openshift-ocp-release-4.10-informing#periodic-ci-openshift-release-master-nightly-4.10-e2e-vsphere-serial

I was able to confirm the newest machine is now getting deleted , attached events.json from the test in private comments 



Moved to Verified.

Comment 22 errata-xmlrpc 2022-03-12 04:34:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056