Bug 1881386

Summary:	Import wizard fails on permission issues for non admin user
Product:	OpenShift Container Platform	Reporter:	Tomas Jelinek <tjelinek>
Component:	Console Kubevirt Plugin	Assignee:	Filip Krepinsky <fkrepins>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.6	CC:	aos-bugs, fkrepins, gouyang, mcarleto
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:44:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2020-09-22 10:44:58 UTC

Description of problem:
A non admin user tries to open the Import VM wizard, he gets an option to pick a provider with no hint that it will not work. If he pick any of the providers, the next thing what happens is that he will be presented by permission error messages with no hint that in general, as a non admin, he will not be able to open run the import.

We need to prevent the user to fall into this trap. We need to either hide the import button for non admin users or we need to open the wizard but dont let him proceed from the first screen and just let him know that only admins are allowed to do this.

Comment 1 Tomas Jelinek 2020-09-22 10:46:12 UTC

@Matt: I think that to be consistent with OCP, we should hide the button completely in case the user is not an admin one. Would you agree?

Comment 2 Matt 2020-09-22 18:32:46 UTC

I'd suggest we just disable it. It would be nice in the future if we could consider adding either a tool tip or sub text that clarifies that it's disabled. Ultimately it would be good to better understand developers and their need for import generally.

Comment 3 Filip Krepinsky 2020-09-23 12:47:42 UTC

clarification: the final decision was to hide the button for the current implementation

Comment 4 Matt 2020-09-23 20:17:41 UTC

no I vote we just disabled it not hide it entirely. That should follow the convention set by the console

Comment 5 Filip Krepinsky 2020-09-24 08:32:14 UTC

that is not easy to do at the moment, since it requires not so simple changes to the console core code.

Comment 6 Filip Krepinsky 2020-09-24 08:34:10 UTC

also it might be convention in other places with dropdowns, but disabling is not used for create dropdowns at the moment.

Comment 7 Matt 2020-09-24 11:58:32 UTC

I'm ok with hiding it for now. We don't have a clear direction yet on how informed developers should be on import if they can't perform it. I'd like to raise this as a larger discussion around what devs should know is possible through admin permissions.

Comment 9 Guohua Ouyang 2020-09-28 00:30:29 UTC

verified on master UI, the import wizard is hiden.

Comment 10 Ilanit Stein 2020-10-04 11:58:11 UTC

*** Bug 1871109 has been marked as a duplicate of this bug. ***

Comment 13 errata-xmlrpc 2020-10-27 16:44:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196