Bug 1881514
Summary: | CVO hotloops on imagestreams from cluster-samples-operator | ||
---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Stefan Schimanski <sttts> |
Component: | Cluster Version Operator | Assignee: | Vadim Rutkovsky <vrutkovs> |
Status: | CLOSED ERRATA | QA Contact: | Yang Yang <yanyang> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 4.6 | CC: | aos-bugs, bleanhar, jack.ottofaro, jokerman, lmohanty, rmarasch, vrutkovs, wking, xiuwang, yanyang |
Target Milestone: | --- | ||
Target Release: | 4.8.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | No Doc Update | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-07-27 22:33:27 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1966977 |
Description
Stefan Schimanski
2020-09-22 14:52:06 UTC
Stefan suggests possibly waiting until API-server support for server-side apply [1] goes GA and rerolling the CVO's apply logic to use that instead of client-side merging, which might help here. And bug 1879184 might end up with a [Late] CI guard based on the audit logs. But whatever is going on here is unlikely to be new in 4.6, so punting to 4.7. [1]: https://kubernetes.io/blog/2020/04/01/kubernetes-1.18-feature-server-side-apply-beta-2/ I don't think #c1 reflect what I meant. I meant that it is an infinite game with lots of chance for mistakes and failure in writing the perfect client-side merging funcs for all types. Instead the right solution is to triage these bugs, fix the manifests for now and add an e2e test that uncovers the issues before new manifests merge. > ... fix the manifests for now... If that's what this bug is about, it should be assigned to the samples team, right? > ... and add an e2e test that uncovers the issues before new manifests merge. This is bug 1879184, right? Punting back to 4.7, because I don't see any new-in-4.6 regressions here, and it's really late in the 4.6 cycle to make new 4.6 blockers unless we have a solid story around why this is a critical issue. > I meant that it is an infinite game with lots of chance for mistakes and failure in writing the perfect client-side merging funcs for all types. Instead the right solution is to triage these bugs, fix the manifests for now
We should have a bug assigned to respective operator team to fix the manifest.
> We should have a bug assigned to respective operator team to fix the manifest.
This is that bug, right? We just don't know what to tell the samples folks they should be changing.
It's end of sprint, and this is not going to get fixed in the next few hours. Hopefully we will at least get the Late audit guard from bug 1879184 in next sprint, and then we'll see which team should fix this issue. Adding UpcomingSprint as we have reached the end of the current sprint and pushing this bug to the next sprint. This makes scheduled importer stop updating, see https://bugzilla.redhat.com/show_bug.cgi?id=1897075. Bumping severity to high Could anyone point me the procedure to reproduce it? I was trying to observe the .metadata.managedFields[0].time but it's not changed. # oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.7.13 True False 21h Cluster version is 4.7.13 # oc get imagestream must-gather -n openshift -ojson | jq -r .metadata { "annotations": { "include.release.openshift.io/ibm-cloud-managed": "true", "include.release.openshift.io/self-managed-high-availability": "true", "include.release.openshift.io/single-node-developer": "true", "include.release.openshift.io/single-node-production-edge": "true" }, "creationTimestamp": "2021-06-02T09:37:37Z", "generation": 2, "managedFields": [ { "apiVersion": "image.openshift.io/v1", "fieldsType": "FieldsV1", "fieldsV1": { "f:metadata": { "f:annotations": { ".": {}, "f:include.release.openshift.io/ibm-cloud-managed": {}, "f:include.release.openshift.io/self-managed-high-availability": {}, "f:include.release.openshift.io/single-node-developer": {}, "f:include.release.openshift.io/single-node-production-edge": {} } }, "f:spec": { "f:tags": { ".": {}, "k:{\"name\":\"latest\"}": { ".": {}, "f:annotations": {}, "f:from": { ".": {}, "f:kind": {}, "f:name": {} }, "f:generation": {}, "f:importPolicy": { ".": {}, "f:scheduled": {} }, "f:name": {}, "f:referencePolicy": { ".": {}, "f:type": {} } } } } }, "manager": "cluster-version-operator", "operation": "Update", "time": "2021-06-02T09:37:37Z" } ], "name": "must-gather", "namespace": "openshift", "resourceVersion": "23674", "uid": "4129abe3-bde7-4bf4-8217-a5c03310be07" } The .metadata.creationTimestamp is the same as .metadata.managedFields[0].time. Does it mean that CVO does not update it? # grep -i "Updating imagestream" cvo.log null I don't find "Updating imagestream" in CVO log either. (In reply to Yang Yang from comment #12) > The .metadata.creationTimestamp is the same as > .metadata.managedFields[0].time. Does it mean that CVO does not update it? Correct > # grep -i "Updating imagestream" cvo.log > null > > > I don't find "Updating imagestream" in CVO log either. The change to log updates verbosely would land in https://github.com/openshift/cluster-version-operator/pull/561, its not there yet Grepping audit logs for updates on the target kind should turn this up. Like [1], but for 'imagestreams' instead of rolebindings. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1881520#c28 Thanks Trevor and Vadim for your help. Reproducing with 4.7.13 $ masters=$(oc get no -l node-role.kubernetes.io/master | sed '1d' | awk '{print $1}') $ oc adm node-logs $masters --path=kube-apiserver/audit.log --raw | zgrep -h '"verb":"update".*"resource":".*imagestreams"' 2>/dev/null | jq -r '.user.username + " " + (.objectRef | .resource + " " + .namespace + " " + .name + " " + .apiGroup) + " " + .stageTimestamp + " " + (.responseStatus | tostring)' | grep imagestream | sort system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:13:18.350801Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:16:52.116254Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:21:13.333628Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:24:49.292675Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:28:19.154926Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:31:59.672553Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:35:53.489343Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:39:23.363201Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:42:58.725996Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:46:36.146882Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli-artifacts image.openshift.io 2021-06-04T02:50:07.862451Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:13:18.154810Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:16:51.918607Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:21:13.129177Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:24:49.089644Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:28:18.962347Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:31:59.478731Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:35:53.305371Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:39:23.177717Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:42:58.538006Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:46:35.962731Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift cli image.openshift.io 2021-06-04T02:50:07.659362Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:13:19.741856Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:16:53.582331Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:21:14.722328Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:24:50.687505Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:28:20.554001Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:32:01.076623Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:35:54.889826Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:39:24.758895Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:43:00.123587Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:46:37.544944Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift hello-openshift image.openshift.io 2021-06-04T02:50:09.259838Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:13:18.745642Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:16:52.521585Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:21:13.723175Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:24:49.686239Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:28:19.552626Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:32:00.075439Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:35:53.895157Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:39:23.765557Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:42:59.125176Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:46:36.543932Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer-artifacts image.openshift.io 2021-06-04T02:50:08.258243Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:13:18.549365Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:16:52.312958Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:21:13.527091Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:24:49.488805Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:28:19.358913Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:31:59.871841Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:35:53.693735Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:39:23.557887Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:42:58.924025Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:46:36.343675Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift installer image.openshift.io 2021-06-04T02:50:08.058345Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:13:19.342628Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:16:53.112513Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:21:14.322371Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:24:50.285705Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:28:20.155903Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:32:00.671161Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:35:54.490838Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:39:24.357924Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:42:59.723782Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:46:37.143230Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift must-gather image.openshift.io 2021-06-04T02:50:08.857599Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:13:19.541364Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:16:53.313618Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:21:14.520943Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:24:50.487203Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:28:20.354853Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:32:00.872161Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:35:54.689903Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:39:24.566795Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:42:59.922870Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:46:37.344117Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift oauth-proxy image.openshift.io 2021-06-04T02:50:09.058366Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:13:18.944338Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:16:52.718384Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:21:13.922362Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:24:49.887075Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:28:19.758395Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:32:00.272621Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:35:54.088160Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:39:23.959824Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:42:59.323004Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:46:36.743157Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tests image.openshift.io 2021-06-04T02:50:08.458515Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:13:19.144204Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:16:52.913053Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:21:14.120607Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:24:50.088247Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:28:19.952674Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:32:00.472495Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:35:54.289021Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:39:24.159460Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:42:59.524725Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:46:36.945209Z {"metadata":{},"code":200} system:serviceaccount:openshift-cluster-version:default imagestreams openshift tools image.openshift.io 2021-06-04T02:50:08.657373Z {"metadata":{},"code":200} All imagestreams in https://github.com/openshift/cluster-samples-operator/blob/master/manifests/08-openshift-imagestreams.yaml are updated every 3~4 minutes. Verifying with 4.8.0-0.nightly-2021-06-02-025513 $ oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.8.0-0.nightly-2021-06-02-025513 True False 78m Cluster version is 4.8.0-0.nightly-2021-06-02-025513 # masters=$(oc get no -l node-role.kubernetes.io/master | sed '1d' | awk '{print $1}') # oc adm node-logs $masters --path=kube-apiserver/audit.log --raw | zgrep -h '"verb":"update".*"resource":".*imagestreams"' 2>/dev/null | jq -r '.user.username + " " + (.objectRef | .resource + " " + .namespace + " " + .name + " " + .apiGroup) + " " + .stageTimestamp + " " + (.responseStatus | tostring)' | grep imagestream | sort null No hotloops on imagestreams. Moving it to verified state. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 |