Bug 1881585

Summary: Review Request: golang-github-projectdiscovery-fdmax - Helper Library to increase automatically the file descriptors
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-04 09:23:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1881363, 1881611    

Description Fabian Affolter 2020-09-22 17:53:50 UTC 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-fdmax.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-projectdiscovery-fdmax-0.0.2-1.fc32.src.rpm

Project URL: https://github.com/projectdiscovery/fdmax

Description:
Small Helper Library to increase automatically the file descriptors limits for
the current process.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52034303

rpmlint output:
$ rpmlint golang-github-projectdiscovery-fdmax-0.0.2-1.fc32.src.rpm 
golang-github-projectdiscovery-fdmax.src: W: invalid-license # FIXME
golang-github-projectdiscovery-fdmax.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint golang-github-projectdiscovery-fdmax-devel-0.0.2-1.fc32.noarch.rpm 
golang-github-projectdiscovery-fdmax-devel.noarch: W: invalid-license # FIXME
golang-github-projectdiscovery-fdmax-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/projectdiscovery/fdmax/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab


The lib has no license at the moment: https://github.com/projectdiscovery/fdmax/issues/3
Comment 1 Fabian Affolter 2020-09-22 18:05:36 UTC 
License was added. It's MIT but no new release published yet.
Comment 2 Robert-André Mauchin 🐧 2020-11-04 10:40:42 UTC 
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Don't forget to fix the license field before import.
Comment 3 Fabian Affolter 2020-11-08 14:26:05 UTC 
Thanks for the review.
Comment 4 Gwyn Ciesla 2020-11-09 16:19:41 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-fdmax