Bug 188204
| Summary: | Review Request: crystal-stacker - Falling blocks, match 3 or more of the same color crystals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Wart <wart> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-09 07:44:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Hans de Goede
2006-04-06 22:29:43 UTC
New version which doesn't pause the music when selecting a new theme (not needed under Unix because we use threads): Spec Name or Url: http://home.zonnet.nl/jwrdegoede/crystal-stacker.spec SRPM Name or Url: http://home.zonnet.nl/jwrdegoede/crystal-stacker-1.5-0.pre.2.src.rpm The theme editor fails to run. It opens up a dialog that says "Editor not installed correctly" Thats strange it works fine over here, can you do a strace on it for me? Hmm, I really can't find anything that explains this, can you see if: /usr/share/crystal-stacker/ce.dat is in place? It is in the specfile so it should be. This file is in place, but it's not the file that the theme editor is looking
for. strace shows that it's looking for this file in the original
RPM_BUILD_ROOT location:
stat64("/var/tmp/crystal-stacker-1.5-0.pre.2-root-wart/usr/share/crystal-stacker/ce.dat",
0xbfe08650) = -1 ENOENT (No such file or directory)
Hmm,
That is most likely because the C-file involved got compiled (again) during make
install where PREFIX is set to $RPM_BUILD_ROOT%{_prefix} so I smell a time skew
problem here, are you using a network filesystem or maybe a filesystem with low
res timestamps or running some kinda time sync software?
Anyways try a rebuild that should fix it.
Yep, the clock in my build machine was behind by several days. Once I reset it then the packages were fine. Here's the full review: MUST ==== * rpmlint output clean * spec file named appropriately * source matches upstream d961dfdc859267b2763f4b585a732f3e cs15src.zip * License (freeware) ok, license file included, license change discussion (to remove non-commercial use clause) included and ok. * No excessive BR: * Compiles, builds, and runs on FC-5 i386 * No locales * No shared libraries * No -devel package * No libtool archives * .desktop file included and installed correctly * Scriptlets are sane * Owns directories that it creates * Contains code and acceptable content APPROVED Thanks, imported and build. |