Bug 1882421

Summary: [RFE]Common Templates with Same OS may have different SRC_PVC_NAME name
Product: OpenShift Container Platform Reporter: Yaacov Zamir <yzamir>
Component: Console Kubevirt PluginAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED DEFERRED QA Contact: Guohua Ouyang <gouyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.6CC: aos-bugs, fkrepins, glekner, rawagner, tjelinek
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-12 13:11:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaacov Zamir 2020-09-24 14:05:23 UTC 
Description of problem:
Common Templates with Same OS may have different SRC_PVC_NAME name, The UI should handle this cases gracefully, or show an error.

Componenets affected:
a - Create VM Wizard:
- When choosing an OS a new disk is created using the latest template available for this OS
- After choosing a flavour or workload, the template used may change, and the disk that was created change.

b - PVC upload and delete:
- When a user choose to upload a disk image for an OS the form uses the SRC_PVC_NAME from the latests template available for that OS, but the user may want to use a flavour/workload that is only available in an older version that uses an older version of the disk0image name.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. change or delete the SRC_PVC_NAME and SRC_PVC_NAMESPACE in a common template for some OS and flavor.
2. go to the wizard and choose this OS.
3. check that the disk created for you use the correct PVC with correct name and name-space.
4. continue with the form and choose the flavour of the template you updated.
5. check the disk image in the   
6. check that the disk created for you use the correct PVC with correct name and name-space.

Actual results:
- the PVC name in step 6 may change to match the new template
- the PVC name in step 6 may not change to match the new template

in both cases user is not aware that the disk image was changed, or that it does not match the new template.

Expected results:
the user get some notice that the disk image is:
- changed from the disk image he sqw in the OS input step.
- or the disk image now does not match the disk image from the template.

Additional info:
On a well maintained system Common Templates with Same OS must have same SRC_PVC_NAME and SRC_PVC_NAMESPACE.
Comment 1 Yaacov Zamir 2020-09-24 14:13:05 UTC 
FYI @Filip @Rastislav @Gilad @Tomas
Comment 2 Yaacov Zamir 2020-09-24 14:19:57 UTC 
Related BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1877834
Comment 3 Filip Krepinsky 2020-09-25 10:47:10 UTC 
regarding the expected results notice:

In the dropdown we don't say what image will be used, so if the image changes, the notice might not be necessary? Especially if we don't know what is the stock image.
But surely, we should show an error if the image is missing.
Comment 4 Yaacov Zamir 2020-10-12 13:11:33 UTC 
Moving to track in JIRA:
https://issues.redhat.com/browse/CNV-7561
Comment 5 Gilad Lekner 2021-01-02 19:28:18 UTC 
Clearing redundant NEEDINFO