Bug 1882486

Summary: Some router tests are broken on e2e-aws-proxy job
Product: OpenShift Container Platform Reporter: Stephen Greene <sgreene>
Component: NetworkingAssignee: Stephen Greene <sgreene>
Networking sub component: router QA Contact: Hongan Li <hongli>
Status: CLOSED WONTFIX Docs Contact:
Severity: medium    
Priority: medium CC: amcdermo, aos-bugs, wking
Version: 4.6   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-18 20:16:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Stephen Greene 2020-09-24 17:37:18 UTC
Routes are not working on the newly revived e2e-aws-proxy job, presumably because the ELB domain is not no-proxied by default.

Eg, see https://prow.ci.openshift.org/view/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-aws-proxy/1308949438701506560

Comment 1 Stephen Greene 2020-09-24 20:07:03 UTC
To clarify this BZ, router e2e tests that curl the ELB url directly with host headers to test a sample route/ingress are not working for the e2e-aws-proxy job, which focuses on cluster proxy egress functionality. 

[sig-network][Feature:Router] The HAProxy router should respond with 503 to unrecognized hosts
[sig-network][Feature:Router] The HAProxy router should serve routes that were created from an ingress
[sig-network][Feature:Router] The HAProxy router should support reencrypt to services backed by a serving certificate automatically 


Additionally, see https://testgrid.k8s.io/redhat-openshift-ocp-release-4.6-informing#periodic-ci-openshift-release-master-ocp-4.6-e2e-aws-proxy

Note that the console operator status test has passed a few times, so to say that routes flat out don't work as is on the e2e-aws-proxy job is naive.

Comment 2 Stephen Greene 2020-09-25 13:16:06 UTC
See skipped tests here https://github.com/openshift/release/pull/12233/files

Comment 5 W. Trevor King 2020-09-25 21:55:18 UTC
As part of fixing this, you should drop at least these skips [1] and show that the test-cases pass in proxy CI.

[1]: https://github.com/openshift/release/blob/4c9dd40104656afb73e609e3c3d39c0c86bc57b4/ci-operator/step-registry/openshift/e2e/aws/proxy/openshift-e2e-aws-proxy-workflow.yaml#L18-L21

Comment 6 W. Trevor King 2020-09-25 21:57:13 UTC
Also maybe 'Image append should create images by appending them', since that also seems to be an issue with the test pod not knowing that it should use the proxy.

Comment 7 Stephen Greene 2020-10-01 15:23:00 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher
priority/severity, developing new features with higher priority, or developing
new features to improve stability at a macro level. I will revisit this bug
next sprint.

Comment 9 Stephen Greene 2020-12-03 15:57:15 UTC
Proxy CI is not feeling well again, so I cannot test my proposed fix at the moment. The team has decided that is appropriate to keep working on proxy CI during the bug fix phase of 4.7, just with lower priority than other bugs.

Comment 12 Andrew McDermott 2021-02-11 18:29:52 UTC
Bumping the priority so we address the skipped tests. 

We will be re-enabling http/2 tests (http/2, gRPC and h2spec) and they may/will also fail with proxy jobs.

Comment 13 Stephen Greene 2021-02-11 18:31:38 UTC
Going to crank the verbosity of the failing tests and churn them through proxy CI to try and figure out the issue here (and if its something we should actually fix).

Comment 14 Stephen Greene 2021-02-11 18:35:40 UTC
Tests that fall under NE responsibility to unskip:

        Managed cluster should should expose cluster services outside the cluster\|
        The HAProxy router should respond with 503 to unrecognized hosts\|
        The HAProxy router should serve routes that were created from an ingress\|
        The HAProxy router should set Forwarded headers appropriately\|
        The HAProxy router should support reencrypt to services backed by a serving certificate automatically\|

Comment 15 Stephen Greene 2021-02-11 18:36:14 UTC
*** Bug 1882853 has been marked as a duplicate of this bug. ***