Bug 1884154

Summary: licensecheck-3.1.1-3.fc34 FTBFS: Failed test 'detect licensing "(GPL-2+ and/or LGPL-2.1+) with SDC exception" for sdc.py'
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: licensecheckAssignee: Sandro Mani <manisandro>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: manisandro
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://koschei.fedoraproject.org/package/licensecheck
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-22 08:15:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1868278    

Description Petr Pisar 2020-10-01 08:13:41 UTC
licensecheck-3.1.1-3.fc34 fails to build in Fedora 34, because a test fails:

t/encoding.t .......... ok
# Failed test 'detect licensing "(GPL-2+ and/or LGPL-2.1+) with SDC exception" for sdc.py'
# at t/exception.t line 179.
# +---------------------------------+----+---------------------------------+
# | GOT                             | OP | CHECK                           |
# +---------------------------------+----+---------------------------------+
# | (GPL-2+ and/or LGPL-2.1) with S | eq | (GPL-2+ and/or LGPL-2.1+) with  |
# | DC exception                    |    | SDC exception                   |
# +---------------------------------+----+---------------------------------+
# Seeded srand with seed '20200925' from local date.
t/exception.t ......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/44 subtests 

A difference between passing and failing build root is at <https://koschei.fedoraproject.org/build/9047532>.

Comment 1 Sandro Mani 2020-11-04 18:22:19 UTC
Builds fine AFAICS: http://koji.fedoraproject.org/koji/taskinfo?taskID=54928989

Comment 2 Petr Pisar 2020-11-05 15:49:05 UTC
I see. Than it's a race in the tests. Look at the flips in a continuous testing <https://koschei.fedoraproject.org/package/licensecheck>.
Running the t/exception.t repeatedly also suffers from this bug:

$ prove -l t/exception.t 
t/exception.t .. ok     
All tests successful.
Files=1, Tests=44,  2 wallclock secs ( 0.03 usr  0.00 sys +  1.57 cusr  0.06 csys =  1.66 CPU)
Result: PASS
[test@fedora-34 App-Licensecheck-v3.1.1]$ prove -l t/exception.t 
t/exception.t .. ok     
All tests successful.
Files=1, Tests=44,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.54 cusr  0.07 csys =  1.65 CPU)
Result: PASS
[test@fedora-34 App-Licensecheck-v3.1.1]$ while prove -l t/exception.t ; do :; done
t/exception.t .. ok     
All tests successful.
Files=1, Tests=44,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.55 cusr  0.08 csys =  1.66 CPU)
Result: PASS
t/exception.t .. 1/44 
# Failed test 'detect licensing "(GPL-2+ and/or LGPL-2.1+) with SDC exception" for sdc.py'
# at t/exception.t line 179.
# +---------------------------------+----+---------------------------------+
# | GOT                             | OP | CHECK                           |
# +---------------------------------+----+---------------------------------+
# | (GPL-2+ and/or LGPL-2.1) with S | eq | (GPL-2+ and/or LGPL-2.1+) with  |
# | DC exception                    |    | SDC exception                   |
# +---------------------------------+----+---------------------------------+
# Seeded srand with seed '20201105' from local date.
t/exception.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/44 subtests

Comment 3 Sandro Mani 2020-11-05 16:01:38 UTC
Is koschei doing something special? I cannot reproduce it locally or firing off multiple scratch builds...

Comment 4 Petr Pisar 2020-11-06 08:11:52 UTC
Koschei perform scratch builds. Nothing special.

Comment 5 Fedora Release Engineering 2020-12-06 04:22:25 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-11-26).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 6 Sandro Mani 2020-12-06 17:08:39 UTC
The package builds successfully [1], I have no idea what koschei is doing, but it's kinda a hard to fix this if it cannot be reproduced elsewhere. And I also don't want the package to be orphaned, so I'll just close it with INSUFFICIENT_DATA. 

[1] https://koji.fedoraproject.org/koji/taskinfo?taskID=56909742s

Comment 7 Petr Pisar 2021-02-08 12:35:55 UTC
I can be reproduced:

$ fedpkg prep

setting SOURCE_DATE_EPOCH=1611619200
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.dmjEDx
+ umask 022
+ cd /home/test/fedora/licensecheck
+ cd /home/test/fedora/licensecheck
+ rm -rf App-Licensecheck-v3.1.1
+ /usr/bin/gzip -dc /home/test/fedora/licensecheck/App-Licensecheck-v3.1.1.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd App-Licensecheck-v3.1.1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ RPM_EC=0
++ jobs -p
+ exit 0
(failed reverse-i-search)`cd-': ^C ..
[test@fedora-34 licensecheck]$ cd App-Licensecheck-v3.1.1
[test@fedora-34 App-Licensecheck-v3.1.1]$ while prove -l t/exception.t; do :; done
t/exception.t .. 1/44 
# Failed test 'detect licensing "(GPL-2+ and/or LGPL-2.1+) with SDC exception" for sdc.py'
# at t/exception.t line 179.
# +---------------------------------+----+---------------------------------+
# | GOT                             | OP | CHECK                           |
# +---------------------------------+----+---------------------------------+
# | (GPL-2+ and/or LGPL-2.1) with S | eq | (GPL-2+ and/or LGPL-2.1+) with  |
# | DC exception                    |    | SDC exception                   |
# +---------------------------------+----+---------------------------------+
t/exception.t .. 43/44 # Seeded srand with seed '20210208' from local date.
t/exception.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/44 subtests 

Test Summary Report
-------------------
t/exception.t (Wstat: 256 Tests: 44 Failed: 1)
  Failed test:  40
  Non-zero exit status: 1
Files=1, Tests=44,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.61 cusr  0.18 csys =  1.82 CPU)
Result: FAIL

Comment 8 Ben Cotton 2021-02-09 15:19:29 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 9 Fedora Release Engineering 2021-02-14 04:22:14 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-11-26).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 10 Fedora Release Engineering 2021-02-14 04:22:15 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 34.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-11-26).

A week before the mass branching of Fedora 35 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 33 will be
retired regardless of the status of this bug.

[1] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedorapeople.org/groups/schedule/f-35/f-35-key-tasks.html

Comment 11 Sandro Mani 2021-06-22 08:15:05 UTC
Fixed in licensecheck-3.2.0.