Bug 1884322

Summary:	RBD clone v2 support THT integration - snapshot deletion
Product:	Red Hat OpenStack	Reporter:	Gregory Charot <gcharot>
Component:	openstack-tripleo-heat-templates	Assignee:	Giulio Fidente <gfidente>
Status:	CLOSED ERRATA	QA Contact:	Luigi Toscano <ltoscano>
Severity:	high	Docs Contact:
Priority:	high
Version:	16.2 (Train)	CC:	abishop, ahyder, eharney, fpantano, gfidente, jamsmith, jobernar, johfulto, jvisser, lmarsh, ltoscano, lyarwood, mburns, nlevinki, pgrist, senrique, shrjoshi, spower, tshefi
Target Milestone:	rc	Keywords:	FeatureBackport, Triaged
Target Release:	16.2 (Train on RHEL 8.4)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-11.4.1-2.20210213010133.6e69097.el8ost	Doc Type:	Bug Fix
Doc Text:	In prior releases, you could not delete snapshots that have snapshot dependencies. With this release, you can delete snapshots that have snapshot dependencies.	Story Points:	---
Clone Of:
Clones:	1968414 (view as bug list)		Environment:
Last Closed:	2021-09-15 07:09:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1764324

Description Gregory Charot 2020-10-01 16:36:52 UTC

Description of problem:

BZ#1764324 tracks RBD clone v2 feature integration, this RFE tracks the tripleO integration.


Version-Release number of selected component (if applicable):

16.2

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 22 Tzach Shefi 2021-03-25 09:47:38 UTC

Luigi, 

Don't know if this is sufficient to verify just letting you know.
Had to check/confirm this was set, while looking into testing RBD cloneV2 RFE bz1764324 on this same deployment. 

On openstack-tripleo-heat-templates-11.4.1-2.20210220005009.a584c40.el8ost.1.noarch
A deployment with ceph resulted in the required setting being added:

[root@controller-2 /]# ceph osd dump
epoch 66
fsid 1382b37a-3366-4b18-9235-7e96024eb09d
created 2021-03-22 09:21:52.485157
modified 2021-03-24 12:30:47.486226
flags sortbitwise,recovery_deletes,purged_snapdirs,pglog_hardlimit
crush_version 7
full_ratio 0.95
backfillfull_ratio 0.9
nearfull_ratio 0.85
require_min_compat_client mimic     -> looks good but do we need to check something else?
min_compat_client jewel
require_osd_release nautilus

Comment 24 Luigi Toscano 2021-03-25 10:10:01 UTC

(In reply to Tzach Shefi from comment #22)
> Luigi, 
> 
> Don't know if this is sufficient to verify just letting you know.
> Had to check/confirm this was set, while looking into testing RBD cloneV2
> RFE bz1764324 on this same deployment. 
> 
> On
> openstack-tripleo-heat-templates-11.4.1-2.20210220005009.a584c40.el8ost.1.
> noarch
> A deployment with ceph resulted in the required setting being added:
> 
> [root@controller-2 /]# ceph osd dump
> epoch 66
> fsid 1382b37a-3366-4b18-9235-7e96024eb09d
> created 2021-03-22 09:21:52.485157
> modified 2021-03-24 12:30:47.486226
> flags sortbitwise,recovery_deletes,purged_snapdirs,pglog_hardlimit
> crush_version 7
> full_ratio 0.95
> backfillfull_ratio 0.9
> nearfull_ratio 0.85
> require_min_compat_client mimic     -> looks good but do we need to check
> something else?
> min_compat_client jewel
> require_osd_release nautilus

This is correct for the scope of this bug. Whether that allows snapshots to work properly, it's in the scope of bug 1764324.

Comment 25 Tzach Shefi 2021-03-29 06:58:58 UTC

Verified on:
openstack-tripleo-heat-templates-11.4.1-2.20210220005009.a584c40.el8ost.1.noarch

THT sets the required option which enables rbdv2 clone on Ceph:
[root@controller-2 /]# ceph osd dump
..
..
require_min_compat_client mimic

Comment 33 Luigi Toscano 2021-08-30 14:28:15 UTC

This feature is now about enabling the required support for successful snapshot deletion only. The specific use case which involves volume deletion has been splitted out and it is tracked by bug 1999155.

Comment 36 errata-xmlrpc 2021-09-15 07:09:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform (RHOSP) 16.2 enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:3483