Bug 188462
Summary: | Review Request: bmp-musepack - Mpegplus (mpc) playback plugin for BMP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthias Saou <matthias> |
Component: | Package Review | Assignee: | Thorsten Leemhuis (ignored mailbox) <bugzilla-sink> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bugs.michael, eric.tanguy |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-04 11:50:46 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matthias Saou
2006-04-10 10:14:09 UTC
Needs work: * Source 0 is not available (http://musepack.origean.net/files/linux/plugins/bmp-musepack-1.2.tar.bz2) (wiki: QAChecklist item 2) * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: gcc-c++ should not be included (wiki: PackagingGuidelines#Exceptions) * A huge blocker is that it fails at run-time. The code formerly taken from XMMS has not been updated to stay in sync with the progress in BMP. The plugin still uses plain fopen() and also libmpcdec's internal stream I/O interface whereas BMP has advanced to implement VFS features. The files/URLs passed on from BMP to the plugins have prefixes like 'file://' or 'http://' and escaped special characters, e.g. %20 for space. The plugin fails to read such input: [xmms-musepack] mpcGetSongInfo is unable to open file:///home/qa/files/audio/test/Paul%20Blackford%20-%20The%20Great%20Bath%20-%20Ambient%20Remake.mpc : No such file or directory [xmms-musepack] mpcGetSongInfo is unable to open http://localhost/test/test.mpc : No such file or directory While it would be trivial to patch the code and strip off a 'file://' prefix to make it work with local files, it would be more work to replace libmpcdec's stream I/O functions with something compatible with the VFS features. * Upstream download location has moved to: http://files2.musepack.net/linux/plugins/bmp-musepack-1.2.tar.bz2 I've contacted the author about this issue. Thanks a lot for spotting it, as I thought I had some strange ape/id3 tag problem on the mpc files I was trying to open with that plugin... Closing as WONTFIX since the author doesn't seem to have time or motivation to fix the plugin, and the newer bmpx is gstreamer-based now anyway. |