Bug 1884728

Summary: Enable arm64 optimizations that exist for power/x86
Product: [Fedora] Fedora Reporter: David Duncan <davdunc>
Component: rubyAssignee: Vít Ondruch <vondruch>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jaruga, mo, mtasaka, pvalena, ruby-packagers-sig, s, strzibny, vanmeeuwen+fedora, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ruby-2.7.2-135.fc34 ruby-2.7.2-135.fc32 ruby-2.7.2-135.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-15 22:33:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
ruby-2.6.6-Enable_arm64_optimizations_that_exist_for_power_x86.patch none

Description David Duncan 2020-10-02 18:18:36 UTC
Created attachment 1718491 [details]
ruby-2.6.6-Enable_arm64_optimizations_that_exist_for_power_x86.patch

This patch enable a set of optimizations that exist already on power and x86 for aarch64/arm64 systems.

When Ali Ran the string benchmarks he found the unaligned access change improves performance by an average of 1.04x, min .96x, max 1.21x, median 1.01x

The gc optimization improves benchmark/gc/hash1 by 5%

The vm_exec changes make a massive difference on some benchmarks (e.g. 1.38x).

A backport that applies cleanly to 2.6.6+ should be appropriate for the 2.7.1 release and anything >3.0.0 where his change has landed. 

I have attached the 2.6.6. patch.

Comment 1 David Duncan 2020-10-02 18:19:50 UTC
(In reply to David Duncan from comment #0)

> A backport that applies cleanly to 2.6.6+ should be appropriate for the
> 2.7.1 release and anything >3.0.0 where his change has landed. 

Sorry for the type-o, I meant <3.0.0 not greater than.

Comment 2 Jun Aruga 2020-10-05 17:05:38 UTC
Thanks for the patch!

I opened the upstream ticket to backport the patch to ruby_2_7 branch here.
https://bugs.ruby-lang.org/issues/17215

Comment 3 Fedora Update System 2020-10-14 12:28:41 UTC
FEDORA-2020-fe2a7d7390 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-fe2a7d7390

Comment 4 Fedora Update System 2020-10-14 13:43:10 UTC
FEDORA-2020-02ca18c2a0 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-02ca18c2a0

Comment 5 Fedora Update System 2020-10-14 14:21:32 UTC
FEDORA-2020-fe2a7d7390 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-fe2a7d7390`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-fe2a7d7390

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-10-15 14:37:01 UTC
FEDORA-2020-02ca18c2a0 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-02ca18c2a0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-02ca18c2a0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-10-15 22:33:27 UTC
FEDORA-2020-02ca18c2a0 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-10-23 22:14:01 UTC
FEDORA-2020-fe2a7d7390 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.