Bug 1884795

Summary: Can't enable Dash-to-Dock in GUI, gnome 3.38
Product: [Fedora] Fedora Reporter: Christopher Morrow <zygexian>
Component: gnome-shell-extension-dash-to-dockAssignee: Björn 'besser82' Esser <besser82>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 33CC: aivaras.laimikis, besser82, brandon.gustav, louisgtwo, mikedep333, nixuser
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-shell-extension-dash-to-dock-69-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-29 01:24:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Christopher Morrow 2020-10-02 19:52:51 UTC 
Description of problem:
After installing the gnome-shell-extension-dash-to-dock package in dnf, The extension shows up as an option in the gnome tweaks GUI, but the toggle button can't be enabled (grayed out) and it has a yellow caution sign next to the name that says "an Error occurred when loading this extension" when you hover over it.

In the gnome extensions GUI, there is a red error sign next to dash-to-dock and it can't be toggled on.

Running `gnome-extensions enable dash-to-dock.com` at the command-line runs the extension with no errors and this is reflected in the GUI. The dock appears to work normally after 


Version-Release number of selected component (if applicable):
gnome-shell-extension-dash-to-dock-68-3.20200911gite2cc441.fc33.noarch (latest in f33 repo as of this report).

How reproducible: I have not attempted yet. I'm a bad man. D:


Steps to Reproduce:
1. Vanilla F33 Beta ISO install
2. `dnf upgrade -y; dnf install -y gnome-shell-extension-dash-to-dock gnome-tweaks`
3. check gnome tweaks in gui and attempt to enable dash-to-dock # error
4. `dnf install -y gnome-extensions-app`
5. check gnome extension gui app and attempt to enable dash-to-dock # error
6. `gnome-extensions enable dash-to-dock.com` # works

Actual results:

Can't enable dash-to-dock from the gnome-tweaks gui or the gnome extensions gui

Expected results:

Should be able to enable dash-to-dock in these programs after install. 

Additional info:

I discovered this bug running the f33 beta iso on Gnome Boxes running on a f32 host (x86 laptop). The only deviations from default were that I enabled disk encryption during install and after install I attempted btrfs compression on the disk with `sudo btrfs filesystem defragment -c -r /; sudo btrfs filesystem defragment -c -r /home` I doubt any of these impacted this bug. I suspect it is something to do with gnome 3.38 or with the dash-to-dock extension. I'm using dash-to-dock on f32 + gnome 3.36 without any issues and I enabled dash-to-dock on the gui on that platform. 

I'm available for contact, and I will attempt to reproduce when I get a few spare cycles.
Comment 1 Brandon Jones 2020-10-09 04:27:22 UTC 
I was experiencing the same bug in the Fedora 33 beta, here is what happened and how I solved the issue:

I tried your workaround using `gnome-extensions enable dash-to-dock.com`, however that did not work after installing the gnome extensions app. What I did notice in the app is that the extension complained about a Dbusmenu version being missing. So I installed `libdbusmenu-gtk3` using dnf (`dnf install libdbusmenu-gtk3`, also pulls in libdbusmenu as a dependency) and logged out and back in. The dock appeared and was slow to populate with icons, but after that, it seems to be working. Some functionality is a little buggy (for example autohide works, but not with the "Push to show: require pressure to show the dock" checked), but overall it seems that the extension depends on libdbusmenu-gtk3 or libdbusmenu, which are not being pulled in when one installs the extension from the repository. 

Hope this helps!
Comment 2 Christopher Morrow 2020-10-09 06:41:56 UTC 
Created my first pull request in Pagure! Adding libdbusmenu-gtk3 to dependencies in the package and that fixed it for me in a f33 VM. https://src.fedoraproject.org/rpms/gnome-shell-extension-dash-to-dock/pull-request/2
Comment 3 Ian Laurie 2020-10-23 05:28:40 UTC 
This is actually a duplicate of bug #1846722 that auto-closed when it shouldn't have.
Comment 4 Ian Laurie 2020-10-24 06:45:13 UTC 
Explicitly installing libdbusmenu-gtk3 does indeed fix the issue.
Comment 5 Fedora Update System 2020-11-20 03:21:02 UTC 
FEDORA-2020-876269be85 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-876269be85
Comment 6 Michael DePaulo 2020-11-20 03:26:59 UTC 
I wish I had gotten to this sooner, but the update is submitted now. Please provide feedback.

I thank you very much for the PR (which I rebased, merged, and updated the changelog and all for.)
Comment 7 louisgtwo 2020-11-20 04:51:38 UTC 
I have been using dash to dock version 69 with fedora 33 without libdbusmenu-gtk3 for a while without issue. I think the version that shipped with fedora 33 needed libdbusmenu-gtk3 for compatibility but version 69 does not need it.
Comment 8 Aivaras Laimikis 2020-11-20 12:11:22 UTC 
After upgrading to gnome-shell-extension-desktop-icons-20.04.0-2.fc33.noarch, desktop-icons still not working. Some errors:

lapkr. 20 14:05:13 acer.local gnome-shell[1905]: JS ERROR: Error: No signal 'allocation-changed' on object 'StWidget'
                                                 _init@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:130:20
                                                 _addDesktopIcons/<@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:193:27
                                                 forEachBackgroundManager@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:766:36
                                                 _addDesktopIcons@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:192:33
                                                 _init@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:89:14
                                                 innerEnable@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/extension.js:64:22
                                                 enable/_startupPreparedId<@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/extension.js:53:94
                                                 _startupAnimationComplete@resource:///org/gnome/shell/ui/layout.js:733:14
                                                 onComplete@resource:///org/gnome/shell/ui/layout.js:711:36
                                                 _makeEaseCallback/<@resource:///org/gnome/shell/ui/environment.js:84:13
                                                 _easeActor/<@resource:///org/gnome/shell/ui/environment.js:167:64
                                                 


lapkr. 20 14:05:16 acer.local gnome-shell[1905]: JS ERROR: TypeError: Extension.desktopManager is null
                                                 _onPressButton@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:520:17
                                                 _init/<@/usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:126:73
Comment 9 Aivaras Laimikis 2020-11-20 12:13:52 UTC 
Please ignore latest comment, it's not related.
Comment 10 Fedora Update System 2020-11-21 02:43:17 UTC 
FEDORA-2020-876269be85 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-876269be85`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-876269be85

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2020-11-29 01:24:54 UTC 
FEDORA-2020-876269be85 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.