Bug 1885321

Summary: Cannot compile code with nss headers and -Werror=strict-prototypes
Product: Red Hat Enterprise Linux 7 Reporter: Bob Relyea <rrelyea>
Component: nssAssignee: Bob Relyea <rrelyea>
Status: CLOSED ERRATA QA Contact: Ivan Nikolchev <inikolch>
Severity: urgent Docs Contact:
Priority: low    
Version: 7.9CC: inikolch, jmaloy, jreznik, mrezanin, nss-nspr-maint, qe-baseos-security, riehecky, rrelyea, ssorce, tis, virt-maint, wquan
Target Milestone: rcKeywords: Triaged, ZStream
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: nss-3.53.1-7.el7_9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1884997 Environment:
Last Closed: 2021-04-27 11:30:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1884997    
Bug Blocks:    

Comment 2 Pat Riehecky 2020-10-05 15:38:19 UTC
Perhaps : https://git.centos.org/rpms/nss/blob/c8/f/SOURCES/nss-3.53-strict-proto-fix.patch ?

(untested, just something I noticed doing tree diffs)

Comment 3 Bob Relyea 2020-10-05 17:23:14 UTC
Re comment 2. Yup, that's the same patch I attached to this bug. Somehow we missed updating RHEL 7.9 with it.

Comment 4 Tuomo Soini 2020-10-05 21:32:00 UTC
Confirmed, that patch fixes qemu-kvm build.

Comment 5 Jon Maloy 2020-11-24 18:12:58 UTC
This is a serious (blocking) problem for us who are building qemu-kvm for RHEL-7.9.z.
Removing -Werror=strict-prototypes is not an option we want to pursue.

Comment 7 Simo Sorce 2020-11-30 17:34:56 UTC
Hi Jon,
although we understand this is causing an issue for you, we think you have several ways to work around this problem in the qemu-kvm build.
For us releasing a new Z-stream requires a lot of work, and has important implications (certifications, QA capacity), so it is unlikely we'll be able to help you with a full release just for this issue.

Comment 8 Quan Wenli 2021-01-07 10:25:40 UTC
Hello Jon Maloy

How can I reproduce this bug, I am not sure how to compile the qemu-kvm with "--strict-protos or -Werror=strict-prototypes" since I can not find any related keywords under "./configure"

Comment 9 Jon Maloy 2021-01-08 00:27:54 UTC
(In reply to Quan Wenli from comment #8)
> Hello Jon Maloy
> 
> How can I reproduce this bug, I am not sure how to compile the qemu-kvm with
> "--strict-protos or -Werror=strict-prototypes" since I can not find any
> related keywords under "./configure"

I don't think you need to reproduce it. This is a relatively trivial build problem and not a security issue.
If you really want to, revert commit 10f48326f30ae89bea01124bdbab4702a21f3655

///jon

Comment 13 Simo Sorce 2021-03-16 19:25:38 UTC
Z given

Comment 21 errata-xmlrpc 2021-04-27 11:30:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: nss security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1384

Comment 22 Red Hat Bugzilla 2023-09-15 00:49:12 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days