Bug 1885684
| Summary: | Review Request: rocm-smi - AMD ROCm System Management Interface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-03-15 21:02:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
Ben Beasley
2020-10-06 17:40:37 UTC
Kudos for starting with koji builds on multiple versions! > https://github.com/RadeonOpenCompute/ROC-smi/archive/rocm-%{version}.tar.gz#/ROC-smi-rocm-%{version}.tar.gz We generally don't use the trick with package renaming anymore. It doesn't hurt, but it introduces additional complexity. Package is simple, everything seems straightforward. + package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly + BR/Requires/Provides look reasonable + builds and installs OK rpmlint: rocm-smi.noarch: W: no-manual-page-for-binary rocm-smi 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Oh, one minor issue: The man page needs to go into %{_mandir}/man1/. That's why rpmlint doesn't find the page. > I have also written a spec file for the SLEEF Vectorized Math Library, which demonstrates my ability to correctly handle more complicated packages than this one: > https://gitlab.com/musicinmybrain/sleef-rpm/-/blob/master/sleef.spec. I have not submitted a review request for that package because there are still a few unresolved test > failures on the s390x platform. Please also submit that. It might be OK to simply exclude the build for s390x or skip the tests... > We generally don't use the trick with package renaming anymore. Adjusted, thanks. > The man page needs to go into %{_mandir}/man1/. That's why rpmlint doesn't find the page. Thanks! A simple typo, now resolved. I’m surprised I didn’t catch it myself. I also found an error in the regex I was using to alter the generated man page, and fixed that as well. > Please also submit that. It might be OK to simply exclude the build for s390x or skip the tests... OK, I can submit that with s390x tests disabled. Upstream claims the package should work on s390x, but the test framework is a little… opaque, so it’s hard to dig into failures if you’re not the upstream maintainer. It might be possible to get somewhere with an upstream bug report, or not. ---- The updated spec file is at the original link. Here is the new batch of koji builds: Fedora 34: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886511 Fedora 33: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886874 Fedora 32: https://koji.fedoraproject.org/koji/taskinfo?taskID=52887198 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886548 EPEL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=52886971 …and the new SRPM: https://kojipkgs.fedoraproject.org//work/tasks/6750/52886750/rocm-smi-3.8.0-1.fc34.src.rpm. Thanks for your input. Package is APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rocm-smi |