Bug 1885900

Summary: [osp16.1][update] Online db migration is not run during external update step.
Product: Red Hat OpenStack Reporter: Sofer Athlan-Guyot <sathlang>
Component: openstack-tripleo-heat-templatesAssignee: Sofer Athlan-Guyot <sathlang>
Status: CLOSED DUPLICATE QA Contact: David Rosenfeld <drosenfe>
Severity: low Docs Contact:
Priority: low    
Version: 16.1 (Train)CC: jstransk, mbollo, mburns
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-19 13:20:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sofer Athlan-Guyot 2020-10-07 09:25:35 UTC 
Description of problem:  Hi,

this issue was first reported there https://review.opendev.org/#/c/755751/

Basically running:

openstack overcloud external-update run --tags online_upgrade

as documented doesn't run online db migration.

The problem is that online db migration are defined for upgrade, but not for update.  This is an instance of the issue[1]


      external_upgrade_tasks:
        - when: step|int == 1
          block:
            - name: Online data migration for Nova
              command: "{{ container_cli }} exec nova_conductor nova-manage db online_data_migrations"
              delegate_to: "{{ groups['nova_conductor'][0] }}"
              become: true
              tags:
                - online_upgrade
                - online_upgrade_nova


There is no equivalent external_update_tasks, so no db migration happen.

Currently we don't see any breakage related to this as we are staying on the same version.

But:
 - this is not working as expected;
 - this break 15->16.1 update new protocol.

So, not a blocker, but should be fixed asap.

[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/train/deployment/nova/nova-conductor-container-puppet.yaml#L264..L274
Comment 1 Jiri Stransky 2020-10-19 13:20:29 UTC 

*** This bug has been marked as a duplicate of bug 1884556 ***