Bug 188601
Summary: | Review Request: ltsp-utils | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Joost Soeterbroek <joost.soeterbroek> | ||||
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | eharrison, jam, pertusus, wtogami | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-04-23 13:27:52 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Joost Soeterbroek
2006-04-11 17:11:52 UTC
This package has Requires on a number of perl modules, most of which are not yet included as packages in FE: [x] perl-Getopt-Long [x] perl-IO-Socket [V] perl-libwww-perl [V] perl-URI [x] perl-Digest-MD5 [x] perl-Term-Cap (In reply to comment #1) > This package has Requires on a number of perl modules, most of which are not yet > included as packages in FE: > > [x] perl-Getopt-Long > [x] perl-IO-Socket > [V] perl-libwww-perl > [V] perl-URI > [x] perl-Digest-MD5 > [x] perl-Term-Cap perl(Getopt::Long), perl(IO::Socket), perl(Digest::MD5), and perl(Term::Cap) are all provided by the main perl package in Core. perl-libwww-perl and perl-URI are both in Core. This may potentially be in conflict with K12LTSP, so please coordinate with Eric Harrison and other K12LTSP people and obtain confirmation, integrate any necessary changes, or maybe an entirely different package is needed. This is a blocker. I have contacted Eric Harrison to see if and where there may be a confilct with K12LTSP. Looks good to me. I considered this a while back when packaging LTSP for K12LTSP. Adding the ltsp-utils package to FE will not cause a problem for existing K12LTSP installations. In fact, I'll probably remove these files from my package and add a requirement for this package. Thanks for the heads-up! The manual perl deps would be better written as: Requires: perl(LWP), perl(URI), perl(Digest::MD5), perl(Term::Cap) These would work even if the modules were moved into differently-named packages. (In reply to comment #3) > This may potentially be in conflict with K12LTSP, so please coordinate with Eric > Harrison and other K12LTSP people and obtain confirmation, integrate any > necessary changes, or maybe an entirely different package is needed. > > This is a blocker. Please remove blocker #188611, see comment #5. Spec URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils.spec SRPM URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils-0.22-2.src.rpm * Wed Apr 12 2006 Joost Soeterbroek <fedora> - 0.22-2 - added Requires for perl(LWP), perl(URI), perl(Digest::MD5), perl(Term::Cap) (In reply to comment #8) > * Wed Apr 12 2006 Joost Soeterbroek <fedora> - 0.22-2 > - added Requires for perl(LWP), perl(URI), perl(Digest::MD5), perl(Term::Cap) The addition of the above deps means that the following can be removed: Requires: perl-libwww-perl Requires: perl-URI Spec URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils.spec SRPM URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils-0.22-3.src.rpm * Wed Apr 12 2006 Joost Soeterbroek <fedora> - 0.22-3 - removed Requires for perl-libwww-perl, perl-URI I meant that contacting Eric Harrison to be sure this doesn't conflict was a blocker. That is now resolved. Spec URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils.spec SRPM URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils-0.25-1.src.rpm * Sat Apr 22 2006 <fedora> - 0.25-1 - rebuild for upstream version 0.25 needs reviewer.. I attach a patch that adds a %clean section, use macros and with attr simplifications. Created attachment 128119 [details]
spec file cleanings, use macros
Spec URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils.spec SRPM URL: http://www.soeterbroek.com/linux/fedora/extras/ltsp-utils/ltsp-utils-0.25-2.src.rpm * Sun Apr 23 2006 Joost Soeterbroek <fedora> - 0.25-2 - applied patch pertusus * rpmlint silent * source match upstream * licence ok, included * spec legible * %clean section * right files * use macros onsistently APPROVED 8116 (ltsp-utils): Build on target fedora-development-extras succeeded. Build logs may be found at http://buildsys.fedoraproject.org/logs/fedora-development-extras/8116-ltsp-utils-0.25-2/ |