Bug 1886031

Summary:	[RFE] satellite maintain should verify the presence of "satellite" or "satellite-capsule" package installed on the server as a pre-upgrade check
Product:	Red Hat Satellite	Reporter:	anerurka
Component:	Satellite Maintain	Assignee:	Amit Upadhye <aupadhye>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.8.0	CC:	ahumbe, apatel, aupadhye, ehelms, gtalreja, kgaikwad, mmccune, pcreech, sokeeffe, thadzhie, zhunting
Target Milestone:	6.9.0	Keywords:	FutureFeature, Triaged
Target Release:	Unused
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	rubygem-foreman_maintain-0.7.5-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1919428 (view as bug list)		Environment:
Last Closed:	2021-04-21 14:48:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description anerurka 2020-10-07 14:04:32 UTC

1. Proposed title of this feature request
[RFE] satellite maintain to verify the presence of satellite version rpm "satellite-6.x.x-x.el7sat.noarch"

2. What is the nature and description of the request?

# satellite-maintain upgrade list-versions does not list any versions for upgrading satellite

3. Why does the customer need this? (List the business requirements here)

This situation occurs whenever a satellite rpm "satellite-6.x.x-x.el7sat.noarch" is missing on the server, due to which target version for upgrade is not listed.

The absence of satellite rpm is not expected behavior and it may be due to the user uninstalling it unknowingly or removed as a dependency for any non-red hat rpm.

4. How would the customer like to achieve this? (List the functional requirements here)

It would be nice to add a check while listing an upgrade version to ensure that satellite rpm is present.

1. Verify Satellite RPM --> For Satellite Server
2. Verify Satellite-Capsule RPM --> For Capsule Server
3. If missing, install the rpm for the right version.

At present, this can be fixed after installing satellite rpm for the appropriate repository.

KCS : https://access.redhat.com/solutions/4330451

5. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.

6. Is there already an existing RFE upstream or in Red Hat Bugzilla?
NA

7. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5,RHEL6)?

Good to have this implemented sooner

Comment 2 Mike McCune 2020-10-14 13:47:28 UTC

Eric, is there a way we could solve this at the packaging level and not have to add additional checks to foreman-maintain?

Comment 3 Eric Helms 2020-11-19 16:01:10 UTC

For Satellite 6.9, we are making the change to ensure the satellite RPM is only available in the Satellite repository and the satellite-capsule RPM is only available in the Capsule repository.

Comment 6 Mike McCune 2020-12-15 18:25:44 UTC

We will work to add a check to foreman-maintain to verify the satellite or satellite-capsule package is installed and error out with a message telling the user to re-install the missing package.

Comment 7 Bryan Kearney 2020-12-24 21:42:13 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/31535 has been resolved.

Comment 14 Gaurav Talreja 2021-03-05 14:11:32 UTC

Verified.

Tested on Satellite 6.9.0 Snap 16.0
Version: rubygem-foreman_maintain-0.7.6-1.el7sat.noarch

Steps:
1. foreman-maintain upgrade list-versions
2. foreman-maintain upgrade check --target-version 6.9.z
3. foreman-maintain upgrade run --target-version 6.9.z

Observation:
satellite-maintain verifies the presence of "satellite" or "satellite-capsule" package installed on the server as a primary check, which runs exactly before the self-upgrade primary check.
And if these packages are missing then gives respective messages for upgrade subcommands as per the satellite-installer scenarios of Satellite and Capsule, like,

Error: Important rpm package satellite/satellite-capsule is not installed!
Install satellite/satellite-capsule rpm to ensure system consistency.

Comment 17 errata-xmlrpc 2021-04-21 14:48:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.9 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1312