Bug 1886040

Summary:	[RFE] Allow installer to unset http proxy environment variables for the duration of it's execution
Product:	Red Hat Satellite	Reporter:	anerurka
Component:	Satellite Maintain	Assignee:	Amit Upadhye <aupadhye>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.8.0	CC:	ahumbe, apatel, aupadhye, ehelms, kgaikwad, sokeeffe, thadzhie
Target Milestone:	6.10.0	Keywords:	FutureFeature, Triaged
Target Release:	Unused
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 13:48:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description anerurka 2020-10-07 14:22:26 UTC

1. Proposed title of this feature request
RFE satellite maintain to unset any proxy environment variable, as a pre-upgrade check

2. What is the nature and description of the request?

If the proxy environment variable is set, the installer run will fail, with the below message.

=====
# satellite-installer 

Please unset the following environment variables before running the installer: http_proxy, https_proxy, ssl_cert_file, HTTP_PROXY, HTTPS_PROXY, SSL_CERT_FILE
Your system does not meet configuration criteria
=====

3. Why does the customer need this? (List the business requirements here)

Since satellite maintain takes care of end to end upgrade, it should also have an additional check to unset an environment variable along with alerting the user.
The addition of this check will ensure that we can avoid the installer execution failure and fixing a potential issue at the pre-upgrade stage.

Currently, it can be executed only on-demand [https://bugzilla.redhat.com/show_bug.cgi?id=1861256#c5]

4. How would the customer like to achieve this? (List the functional requirements here)

Additional check-in pre-upgrade to identify any proxy environment variable


5. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.

NA

6. Is there already an existing RFE upstream or in Red Hat Bugzilla?
NA

7. Does the customer have any specific timeline dependencies and which release would  they  like  to  target  (i.e.  RHEL5,RHEL6)?

Good to have this implemented sooner

Comment 2 Bryan Kearney 2021-04-22 12:07:05 UTC

Upstream bug assigned to aupadhye

Comment 5 Gaurav Talreja 2021-07-09 08:20:02 UTC

Verified.

Tested on Satellite 6.10.0 Snap 8.0

Steps:
1. Export any environment variable from [http_proxy, https_proxy, ssl_cert_file, HTTP_PROXY, HTTPS_PROXY, SSL_CERT_FILE]
2. satellite-installer

Observations:
satellite-installer unsets system proxy and SSL environment variables only for the duration of install and sets back those in the end.

Comment 8 errata-xmlrpc 2021-11-16 13:48:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.10 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4697