Bug 1886166

Summary: 1885517 Clone - Not needed for 4.7 - upgrade from 4.5->4.6 causes broadcast storm
Product: OpenShift Container Platform Reporter: Tim Rozet <trozet>
Component: NetworkingAssignee: Tim Rozet <trozet>
Networking sub component: ovn-kubernetes QA Contact: Anurag saxena <anusaxen>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: urgent CC: rbrattai
Version: 4.6   
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-24 15:23:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1885517    

Description Tim Rozet 2020-10-07 19:20:05 UTC 
Description of problem:
See https://bugzilla.redhat.com/show_bug.cgi?id=1885517 for full description.

tl;dr from old local gateway mode in 4.5 -> 4.6 upgrade we are not cleaning up an old port from the previous gateway mode (br-local_<node name>). This is not applicable to 4.7, because this port will never exist in 4.6->4.7 upgrade on the external switch.

Way to verify on a new 4.6 setup, look at ovn-nbctl external switch (ext_<node name>):

switch 89dea851-8220-4ae2-9881-704c79e61dae (ext_worker-0-0)
    port etor-GR_worker-0-0
        type: router
        addresses: ["52:54:00:94:dc:86"]
        router-port: rtoe-GR_worker-0-0
    port br-ex_worker-0-0
        type: localnet
        addresses: ["unknown"]

It should only have br-ex_<node name> as a localnet type port. In 4.5->4.6 upgrade with current bug, the following port is leftover:


switch 89dea851-8220-4ae2-9881-704c79e61dae (ext_worker-0-0)
    port etor-GR_worker-0-0
        type: router
        addresses: ["52:54:00:94:dc:86"]
        router-port: rtoe-GR_worker-0-0
    port br-ex_worker-0-0
        type: localnet
        addresses: ["unknown"]
    port br-local_worker-0-0            <------leftover from 4.5
        type: localnet
        addresses: ["unknown"]
Comment 1 Tim Rozet 2020-10-07 19:21:47 UTC 
QE please confirm we can skip fixing this for 4.7 since it is only applicable to 4.5->4.6 upgrade.
Comment 2 Ross Brattain 2020-10-07 19:25:58 UTC 
Only needed for 4.6
Comment 5 errata-xmlrpc 2021-02-24 15:23:52 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633