Bug 1886416

Summary: Uninstall 4.6: ocs-operator logging regarding noobaa-core PVC needs change
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Neha Berry <nberry>
Component: ocs-operatorAssignee: Nitin Goyal <nigoyal>
Status: CLOSED ERRATA QA Contact: Anna Sandler <asandler>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.6CC: ebenahar, jarrpa, madam, muagarwa, nigoyal, ocs-bugs, rtalur, sostapov
Target Milestone: ---   
Target Release: OCS 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-19 09:15:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Storagecluster yaml before deletion none

Description Neha Berry 2020-10-08 12:17:05 UTC
Created attachment 1719943 [details]
Storagecluster yaml before deletion

Description of problem (please be detailed as possible and provide log
snippests):
------------------------------------------------
In OCS 4.6, with default annotations (graceful uninstall), the noobaa and other resources are deleted and their status is check.

In below snip the msg is  ""NooBaa and noobaa-core PVC not found." . IMO, it should be ""NooBaa and noobaa-db PVC not found.""


{"level":"info","ts":"2020-10-08T11:33:49.002Z","logger":"controller_storagecluster","msg":"Uninstall: NooBaa not found, can't set UninstallModeForced","Request.Namespace":"openshift-storage","Request.Name":"ocs-storagecluster"}
{"level":"info","ts":"2020-10-08T11:33:49.002Z","logger":"controller_storagecluster","msg":"NooBaa and noobaa-core PVC not found.","Request.Namespace":"openshift-storage","Request.Name":"ocs-storagecluster"}



Version of all relevant components (if applicable):
========================================
OCS = ocs-operator.v4.6.0-569.ci
OCP = 4.6.0-0.nightly-2020-09-28-061045


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
-----------------------------------------
No. Just logging changes needed.

Is there any workaround available to the best of your knowledge?
-------------------------------------------
Not needed

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
---------------------------------------
3

Can this issue reproducible?
----------------------
tested once

Can this issue reproduce from the UI?
-----------------------
NA

If this is a regression, please provide more details to justify this:
-----------------------------------------
New changes in 4.6

Steps to Reproduce:
------------------------
1. Create an OCS 4.6 cluster . make sure the default annotations in storagecluster are set

annotations:
    uninstall.ocs.openshift.io/cleanup-policy: delete
    uninstall.ocs.openshift.io/mode: graceful

2. Delete all PVCs except noobaa-db
3. Delete storagecluster
 
oc delete -n openshift-storage storagecluster --all --wait=true

4. The storagecluster deletion waits till internally noobaa, noobaa-db pvc, cephcluster etc are deleted.

5. Keep a check on the ocs-operator log to track uninstall process

 oc logs ocs-operator-67985fd679-ddwxj

Actual results:
---------------
"msg":"NooBaa and noobaa-core PVC not found."

Expected results:
================
IMO, it should be ""msg":"NooBaa and noobaa-db PVC not found.""

Additional info:

Comment 3 Mudit Agarwal 2020-10-09 11:08:16 UTC
Talur, pls check if this can fixed in 4.6

Comment 4 Jose A. Rivera 2020-10-12 14:54:36 UTC
This is not a blocker for OCS 4.6, moving to OCS 4.7.

Comment 5 Nitin Goyal 2020-10-20 12:05:20 UTC
Clearing need info on talur as PR is raised

https://github.com/openshift/ocs-operator/pull/854

Comment 8 Anna Sandler 2021-02-25 15:00:48 UTC
{"level":"info","ts":1614265091.7384686,"logger":"controllers.StorageCluster","msg":"Uninstall: NooBaa and noobaa-db PVC not found.","Request.Namespace":"openshift-storage","Request.Name":"ocs-storagecluster"}

moving to verified

Comment 11 errata-xmlrpc 2021-05-19 09:15:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2041