Bug 1886647

Summary:	Unable to upgrade from rhvh 4.4.1 to 4.4.2 as block storage domains are detected as local storage domains.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Ameya Charekar <achareka>
Component:	redhat-virtualization-host	Assignee:	Nir Levy <nlevy>
Status:	CLOSED ERRATA	QA Contact:	peyu
Severity:	urgent	Docs Contact:
Priority:	high
Version:	4.4.2	CC:	cshao, dfediuck, gveitmic, jortialc, lsvaty, mavital, nlevy, peyu, sbonazzo, shlei, weiwang, yaniwang
Target Milestone:	ovirt-4.4.3-1	Keywords:	Regression, TestBlocker
Target Release:	4.4.3
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	redhat-virtualization-host-4.4.3-20201105.1.el8_3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-24 13:14:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1883157
Bug Blocks:

Description Ameya Charekar 2020-10-09 03:06:56 UTC

Description of problem:

Upgrading host from rhvh-4.4.1 to rhvh-4.4.2 fails if environment has block storage domain(s). 

Manually installing package shows block storage domain is detected wrongly as local storage domain.

~~~
Local storage domains were found on the same filesystem as / ! Please migrate the data to a new LV before upgrading, or you will lose the VMs
See: https://bugzilla.redhat.com/show_bug.cgi?id=1550205#c3
Storage domains were found in:
	/rhev/data-center/mnt/blockSD/<uuid>/dom_md
error: %prein(redhat-virtualization-host-image-update-4.4.2-20200930.0.el8_2.noarch) scriptlet failed, exit status 1

Error in PREIN scriptlet in rpm package redhat-virtualization-host-image-update
~~~

Version-Release number of selected component (if applicable):
rhvm-4.4.2.6-0.2.el8ev.noarch
ovirt-host-4.4.1-4.el8ev.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Upgrade host from RHV-M or manually after placing host in maintenance mode.
2.   
3.

Actual results:
Host fails to upgrade.

Expected results:
Host should upgrade without any errors if there are no local storage domains on /.

Additional info:

Comment 9 Sandro Bonazzola 2020-10-14 12:40:32 UTC

See also bug #1883157 which was reported upstream.

Comment 11 Sandro Bonazzola 2020-10-14 14:31:32 UTC

Marking as regression, upgrade with iSCSI storage must work.

Comment 16 peyu 2020-10-27 12:11:59 UTC

The bug has been resolved on "redhat-virtualization-host-4.4.3-20201026.0.el8_3"

Test Version:
RHVH: redhat-virtualization-host-4.4.3-20201026.0.el8_3
RHVM: 4.4.3.7-0.22.el8ev


Test Steps:
1. Install redhat-virtualization-host-4.4.2-20200930.0.el8_2 on an iSCSI machine
2. Setup local repos and point to "redhat-virtualization-host-4.4.3-20201026.0.el8_3"
3. Add host to RHVM
4. Add a iSCSI storage domain and wait for its status to become "Active"
5. Add a VM 
6. Manage the host to maintenance mode
7. Upgrade the host
   # yum update
   # reboot
8. Activate the host via RHVM
9. Start the VM

Actual results:
Upgrade is successful. The status of the iSISI storage domain is "Active" and the VM can start up successful after the upgrade. 

Also checked Bug 1852721, this fix has no effect on it.

Move the bug status to "VERIFIED".

Comment 22 peyu 2020-11-12 04:54:41 UTC

QE tested the latest build(redhat-virtualization-host-4.4.3-20201105.1.el8_3) in a host with FC storage domains，it works.

Test Version:
RHVH: redhat-virtualization-host-4.4.3-20201105.1.el8_3
      redhat-virtualization-host-4.4.1-20200722.0.el8_2
RHVM: 4.4.3.9-0.1.el8ev


Test environment:
A machine with one local disk and one RemoteStorage FC.

Test Steps:
1. Install redhat-virtualization-host-4.4.1-20200722.0.el8_2 on the local disk
2. Setup local repos and point to "redhat-virtualization-host-4.4.3-20201105.1.el8_3"
3. Add host to RHVM
4. Add a FC storage domain and wait for its status to become "Active"
5. Add a VM 
6. Manage the host to maintenance mode
7. Upgrade the host
   # yum update
   # reboot
8. Activate the host via RHVM
9. Start the VM

Actual results:
Upgrade is successful. The status of the FC storage domain is "Active" and the VM can start up successful after the upgrade.

Comment 26 errata-xmlrpc 2020-11-24 13:14:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5218