Bug 1886837

Summary:	Revise PKINIT upgrade code
Product:	Red Hat Enterprise Linux 8	Reporter:	Thorsten Scherf <tscherf>
Component:	ipa	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED ERRATA	QA Contact:	ipa-qe <ipa-qe>
Severity:	high	Docs Contact:
Priority:	high
Version:	8.0	CC:	amore, antorres, ksiddiqu, pasik, pvoborni, rcritten, ssidhaye, tscherf
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	idm-client-8050020210701113027.de73ecb2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-09 18:21:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thorsten Scherf 2020-10-09 13:56:43 UTC

This bug is created as a clone of upstream ticket:
https://pagure.io/freeipa/issue/8532

I am reading through PKINIT upgrade and setup code and I think we have logical bug in ipa-pkinit-manage and in the upgrade code:
1. ipa-pkinit-manage never calls krbinstance's setup_pkinit() on enable, so we are never able to enable the certificate issuance through it even though we are able to disable one
2. upgrade code only allows to issue self-signed certificates if certificates are missing

as a result, there is no way to upgrade from self-signed to CA-based and the way it is done, even if you'd do reissue, the issuer will still be left `cn=<hostname>`, without EKUs we need, so it will not work for web UI logon FAST wrapping.

We have to reissue cert properly and there is nothing that would do it -- as nothing calls into krb instance's `setup_pkinit()`.

a manual fix is to force reissue of the PKINIT certificate against the right CA with right issuer and EKUs:
```
ipa-getcert rekey -f /var/kerberos/krb5kdc/kdc.crt -U id-kp-serverAuth -U id-pkinit-KPKdc -K krbtgt/IPA.TEST -T KDCs_PKINIT_Certs -X IPA
```

but we need to revise upgrade code and `ipa-pkinit-manage` to make sure we are taking care of the conversion of 'bogus' PKINIT certificate to the correct one, whether self-signed or IPA CA.

Comment 5 Rob Crittenden 2021-06-17 21:30:06 UTC

Fixed upstream
master:
https://pagure.io/freeipa/c/50306cc636955ff5e478819e98224953cb6346ee

Comment 6 Rob Crittenden 2021-06-18 14:44:36 UTC

Fixed upstream
ipa-4-6:
https://pagure.io/freeipa/c/16ee41b4e42060a8fcf06369d42dedf2c0ee703c

Fixed upstream
ipa-4-9:
https://pagure.io/freeipa/c/7bed7e4b06e70b04e16410878ad269564291eec4

Comment 13 anuja 2021-08-02 09:25:57 UTC

Verigied using sanity ceck:
using upstream-pkinit-manage

(A) test-result.txt.gz
============================= test session starts ==============================
platform linux -- Python 3.6.8, pytest-3.10.1, py-1.10.0, pluggy-0.13.1 -- /usr/libexec/platform-python
cachedir: /home/cloud-user/.pytest_cache
metadata: {'Python': '3.6.8', 'Platform': 'Linux-4.18.0-324.el8.x86_64-x86_64-with-redhat-8.5-Ootpa', 'Packages': {'pytest': '3.10.1', 'py': '1.10.0', 'pluggy': '0.13.1'}, 'Plugins': {'metadata': '1.11.0', 'html': '1.22.1', 'multihost': '3.0', 'sourceorder': '0.5'}}
rootdir: /usr/lib/python3.6/site-packages/ipatests, inifile:
plugins: metadata-1.11.0, html-1.22.1, multihost-3.0, sourceorder-0.5
collecting ... collected 5 items

test_integration/test_pkinit_manage.py::TestPkinitManage::test_pkinit_enable PASSED [ 20%]
test_integration/test_pkinit_manage.py::TestPkinitManage::test_pkinit_disable PASSED [ 40%]
test_integration/test_pkinit_manage.py::TestPkinitManage::test_pkinit_reenable PASSED [ 60%]
test_integration/test_pkinit_manage.py::TestPkinitManage::test_pkinit_on_replica PASSED [ 80%]
test_integration/test_pkinit_manage.py::TestPkinitInstall::test_pkinit PASSED [100%]

(B) runner.log 
2021-07-30T10:10:05+0000 ok: [master.testrelm.test] => (item=ipa-server) => 
2021-07-30T10:10:05+0000   msg:
2021-07-30T10:10:05+0000   - arch: x86_64
2021-07-30T10:10:05+0000     epoch: null
2021-07-30T10:10:05+0000     name: ipa-server
2021-07-30T10:10:05+0000     release: 4.module+el8.5.0+11912+1b4496cf
2021-07-30T10:10:05+0000     source: rpm
2021-07-30T10:10:05+0000     version: 4.9.6

Comment 16 errata-xmlrpc 2021-11-09 18:21:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ipa bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4230