Bug 1886887

Summary: Running service lacks one of the tags assigned to it during service order
Product: Red Hat CloudForms Management Engine Reporter: mheppler
Component: AutomateAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.11.8CC: dmetzger, fdewaley, juwatts, mzazrivec, obarenbo, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.11.10Flags: simaishi: cfme-5.11.z+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.10.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-15 21:17:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
5.11.10 screenshot none

Comment 3 Milan Zázrivec 2020-10-13 14:39:44 UTC
Unlike what the initial comment says, this bug is in no way related to bug #1713205.

Based on reading the linked customer case, I'm adding bug description, which reflects
what the customer reported.

Description of problem:
Running service lacks one of the tags assigned to it during service order, when using service
dialog with tag control and multiple tags were chosen during order.

Version-Release number of selected component (if applicable):
CFME 5.11.8

How reproducible:
Always

Steps to Reproduce:
1. Create a service dialog, add a Tag control element to it
2. Make sure the selected tag in the above tag control element allows multiple choices
3. Add the above created service dialog to a catalog item (a generic catalog item for example)
4. Order the above created catalog item and select at least two tags in the presented dialog
5. Check the order request details page, see if it contains info about all selected tags
6. Check the created service, see if it mentions all selected tags

Actual results:
The request page doesn't mention the first selected tag. The running service also doesn't mention
the first selected tag.

Expected results:
No tag is being discarded during / after service order.

Additional info:
N/A

Comment 6 CFME Bot 2020-10-15 18:20:53 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/aa67617a8eb013c39124ad5516dae615a4a683d6
commit aa67617a8eb013c39124ad5516dae615a4a683d6
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Tue Oct 13 15:13:21 2020 +0000
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Tue Oct 13 15:13:21 2020 +0000

    Correctly render multi-tags in request details dialog

    https://bugzilla.redhat.com/show_bug.cgi?id=1886887

 app/views/miq_request/_request_dialog_details.html.haml | 8 +-
 1 file changed, 5 insertions(+), 3 deletions(-)

Comment 7 mheppler 2020-10-26 12:17:47 UTC
Please, it is possible to make hotfix for customer? Thanks...

Comment 8 dmetzger 2020-10-27 14:23:51 UTC
Please make the hot fix request through the cf-hotfix mail list so it can be approved / prioritized / scheduled.

Comment 9 Felix Dewaleyne 2020-10-28 09:59:56 UTC
as michal is away I'll continue the hotfix request.

Comment 10 Milan Zázrivec 2020-10-29 11:34:41 UTC
The backend fix for the bug is not merged yet.

Comment 11 Felix Dewaleyne 2020-11-09 14:00:46 UTC
customer has decided to wait until errata release.

Comment 12 CFME Bot 2020-11-11 14:30:13 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/ef194a62bc1064a2ae71532ea2e42e07f3d21c14
commit ef194a62bc1064a2ae71532ea2e42e07f3d21c14
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Tue Oct 13 15:35:28 2020 +0000
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Tue Oct 20 14:26:17 2020 +0000

    Fix automate_output_value() for tag control

    https://bugzilla.redhat.com/show_bug.cgi?id=1886887

 app/models/dialog_field_tag_control.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 13 CFME Bot 2020-11-11 16:30:31 UTC
New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/4f865815187d3d054b5b4ea9c99a2b9ae10d0bf7
commit 4f865815187d3d054b5b4ea9c99a2b9ae10d0bf7
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Oct 15 18:18:11 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Nov 11 16:27:33 2020 +0000

    Merge pull request #7419 from mzazrivec/render_multi_tags_in_request_dialog_details

    Correctly render multi-tags in request details dialog

    (cherry picked from commit 20f2cd5c7e65ea776a9927ef2d7a3370048fd295)

    https://bugzilla.redhat.com/show_bug.cgi?id=1886887

 app/views/miq_request/_request_dialog_details.html.haml | 8 +-
 1 file changed, 5 insertions(+), 3 deletions(-)

Comment 14 CFME Bot 2020-11-11 16:30:38 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/cdd35487cad20bf1b684201dbceb6dda147fa387
commit cdd35487cad20bf1b684201dbceb6dda147fa387
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Wed Nov 11 14:29:33 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Nov 11 15:41:59 2020 +0000

    Merge pull request #20685 from mzazrivec/fix_automate_output_value_for_tag_control

    Fix automate_output_value() for tag control

    (cherry picked from commit 2f545e0809d69f5e153bdb6d4a89325e7cc0e1e0)

    https://bugzilla.redhat.com/show_bug.cgi?id=1886887

 app/models/dialog_field_tag_control.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 15 Niyaz Akhtar Ansari 2020-12-01 17:40:20 UTC
Created attachment 1735342 [details]
5.11.10 screenshot

Comment 21 errata-xmlrpc 2020-12-15 21:17:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: CloudForms 5.0.10 security, bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5554