Bug 1887842
| Summary: | Review Request: gitjacker - Leak git repositories from misconfigured websites | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-28 02:10:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1882895 | ||
| Bug Blocks: | 1269538 | ||
|
Description
Fabian Affolter
2020-10-13 12:49:59 UTC
Test fails:
Testing in: /builddir/build/BUILD/gitjacker-0.0.2/_build/src
PATH: /builddir/build/BUILD/gitjacker-0.0.2/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
GOPATH: /builddir/build/BUILD/gitjacker-0.0.2/_build:/usr/share/gocode
GO111MODULE: off
command: go test -buildmode pie -compiler gc -ldflags " -X github.com/liamg/gitjacker/version=0.0.2 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
testing: github.com/liamg/gitjacker
github.com/liamg/gitjacker/internal/pkg/gitjacker
--- FAIL: TestRetrieval (0.00s)
retriever_test.go:93: exec: "git": executable file not found in $PATH
FAIL
exit status 1
FAIL github.com/liamg/gitjacker/internal/pkg/gitjacker 0.004s
Add git-core to the BR:
%if %{with check}
# Tests
BuildRequires: golang(github.com/magiconair/properties/assert)
BuildRequires: git-core
%endif
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package approved. Please fix the aforementioned issue before import.
(In reply to Robert-André Mauchin 🐧 from comment #1) > Add git-core to the BR: I will add it. Thanks for the review. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gitjacker FEDORA-2020-1c6cb2d9bc has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-1c6cb2d9bc FEDORA-2020-1c6cb2d9bc has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-1c6cb2d9bc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1c6cb2d9bc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-1c6cb2d9bc has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-38497c254f has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-38497c254f FEDORA-2020-dd863fcc61 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-dd863fcc61` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-dd863fcc61 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-dd863fcc61 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |