Bug 1887843

Summary:	VIRTIO_F_IOMMU_PLATFORM was renamed to VIRTIO_F_ACCESS_PLATFORM - fix in Windows drivers
Product:	Red Hat Enterprise Linux 8	Reporter:	Basil Salman <bsalman>
Component:	virtio-win	Assignee:	Basil Salman <bsalman>
virtio-win sub component:	virtio-win-prewhql	QA Contact:	lijin <lijin>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	demeng, jinzhao, juzhang, kanderso, menli, phou, vrozenfe, yvugenfi
Version:	8.3	Keywords:	RFE
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-16 14:24:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Basil Salman 2020-10-13 13:00:43 UTC

Description of problem:

According to the spec - https://docs.oasis-open.org/virtio/virtio/v1.1/csprd01/virtio-v1.1-csprd01.html: VIRTIO_F_ACCESS_PLATFORM(33) This feature indicates that the device can be used on a platform where device access to data in memory is limited and/or translated. E.g. this is the case if the device can be located behind an IOMMU that translates bus addresses from the device into physical addresses in memory, if the device can be limited to only access certain memory addresses or if special commands such as a cache flush can be needed to synchronise data in memory with the device. Whether accesses are actually limited or translated is described by platform-specific means. If this feature bit is set to 0, then the device has same access to memory addresses supplied to it as the driver has. In particular, the device will always use physical addresses matching addresses used by the driver (typically meaning physical addresses used by the CPU) and not translated further, and can access any address supplied to it by the driver. When clear, this overrides any platform-specific description of whether device access is limited or translated in any way, e.g. whether an IOMMU may be present.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 6 menli@redhat.com 2020-12-01 06:01:51 UTC

Test viostor and rng driver, looks good, thanks

Comment 7 Peixiu Hou 2020-12-01 06:14:10 UTC

Tested with netkvm, vioscsi and vioinput driver, iommmu jobs all passed.

Tested os: Win10-32, Win2019

Used versions:
kernel-4.18.0-240.5.1.el8_3.x86_64
qemu-kvm-5.1.0-15.module+el8.3.1+8772+a3fdeccd.x86_64
virtio-win-prewhql-191
seabios-bin-1.13.0-2.module+el8.3.0+7353+9de0a3cc.noarch

Auto Job results:
On Win10-32:
 (1/6) io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads: PASS (1268.36 s)
 (2/6) type_specific.io-github-autotest-qemu.vioinput_keyboard.iommu_enabled: PASS (533.33 s)
 (3/6) type_specific.io-github-autotest-qemu.boot_nic_with_iommu: PASS (118.15 s)
 (4/6) type_specific.io-github-autotest-qemu.vioinput_mice.iommu_enabled.device_mouse: PASS (463.69 s)
 (5/6) type_specific.io-github-autotest-qemu.vioinput_mice.iommu_enabled.device_tablet: PASS (411.13 s)
 (6/6) type_specific.io-github-autotest-qemu.block_with_iommu.with_installation.cdrom.extra_cdrom_ks: PASS (1108.37 s)
On Win2019:
 (1/5) type_specific.io-github-autotest-qemu.block_with_iommu.with_installation.cdrom.extra_cdrom_ks: PASS (921.18 s)
 (2/5) type_specific.io-github-autotest-qemu.vioinput_mice.iommu_enabled.device_mouse: PASS (352.69 s)
 (3/5) type_specific.io-github-autotest-qemu.vioinput_mice.iommu_enabled.device_tablet: PASS (271.46 s)
 (4/5) type_specific.io-github-autotest-qemu.vioinput_keyboard.iommu_enabled: PASS (338.64 s)
 (5/5) type_specific.io-github-autotest-qemu.boot_nic_with_iommu: PASS (81.66 s)

Thanks~
Peixiu

Comment 8 lijin 2020-12-01 06:49:56 UTC

Set status to verified according to comment#3 to comment#7

Comment 11 errata-xmlrpc 2021-02-16 14:24:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:0535