Bug 1888419

Summary: VDO target driver should support dmsetup rename
Product: Red Hat Enterprise Linux 8 Reporter: bjohnsto
Component: kmod-kvdoAssignee: bjohnsto
Status: CLOSED ERRATA QA Contact: Filip Suba <fsuba>
Severity: medium Docs Contact: Marek Suchánek <msuchane>
Priority: unspecified    
Version: 8.4CC: awalsh, cwei, emcnabb, fsuba, pasik, zkabelac
Target Milestone: rc   
Target Release: 8.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 6.2.4.23 Doc Type: Enhancement
Doc Text:
Suggested text: To better support the LVM+VDO implementation, the kvdo implementation is now able to support renaming the VDO device name.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 14:39:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1683950, 1881955    

Description bjohnsto 2020-10-14 19:41:32 UTC
Description of problem:

VDO driver currently does not support dmsetup rename operation.

Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1. Call dmsetup reload on VDO to change poolName to new name.
2. Call dmsetup rename to change the name of VDO device to new name.
3. Call dmsetup resume to resume new name.

Actual results:

Error or blocked operation

Expected results:

Successful rename

Additional info:

Comment 3 Filip Suba 2020-11-12 12:50:33 UTC
Verified with kmod-kvdo-6.2.4.26-75.el8.

# dmsetup reload vdo --table "0 19487242776 vdo V2 /dev/disk/by-id/scsi-35000cca26c1a0a38 2441609216 4096 32768 16380 on auto vdo1 maxDiscard 1 ack 1 bio 4 bioRotationInterval 64 cpu 2 hash 1 logical 1 physical 1"
# dmsetup rename vdo vdo1
# dmsetup resume vdo1
# vdostats /dev/mapper/vdo1
Device               1K-blocks      Used Available Use% Space saving%
/dev/mapper/vdo1     9766436864  10785784 9755651080   0%           N/A

[14471.703359] kvdo3:dmsetup: Using write policy async automatically.
[14471.709545] kvdo3:dmsetup: preparing to modify device 'vdo1'
[14486.165672] kvdo3:dmsetup: suspending device 'vdo'
[14486.186413] kvdo3:dmsetup: device 'vdo' suspended
[14486.191313] kvdo3:dmsetup: resuming device 'vdo1'
[14486.196023] kvdo3:dmsetup: Modifying device 'vdo1' pool name from vdo to vdo1
[14486.203165] kvdo3:dmsetup: Modify pool name from vdo to vdo1
[14486.236771] kvdo3:dmsetup: device 'vdo1' resumed

Comment 4 bjohnsto 2021-04-30 21:11:02 UTC
*** Bug 1881955 has been marked as a duplicate of this bug. ***

Comment 6 errata-xmlrpc 2021-05-18 14:39:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1588