Bug 1888430

Summary: Cypress: Fix 'aria-hidden-focus' accesibility violations
Product: OpenShift Container Platform Reporter: OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component: Management ConsoleAssignee: David Taylor <dtaylor>
Status: CLOSED WONTFIX QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.6.zCC: aos-bugs, jhadvig, jokerman, spadgett
Target Milestone: ---Keywords: Reopened, UpcomingSprint
Target Release: 4.6.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-11 10:24:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1885702, 1888985    
Bug Blocks:    

Description OpenShift BugZilla Robot 2020-10-14 20:22:05 UTC
+++ This bug was initially created as a clone of Bug #1885702 +++

Created attachment 1719478 [details]
Cypress a11y violations info.

The 3 'aria-hidden-focus' a11y viloations in these Cypress tests:

*Running: crud/namespace-crud.spec.ts*

1 accessibility violation was detected for Create Namespace modal

'aria-hidden-focus' │ 'serious' │ 'Ensures aria-hidden elements do not contain focusable elements' │ 1 │
       delete the Namespace

1 accessibility violation was detected for Delete Namespace modal

'aria-hidden-focus' │ 'serious' │ 'Ensures aria-hidden elements do not contain focusable elements' │ 1 │
       delete project

 
Running: monitoring/monitoring.spec.ts

1 accessibility violation was detected for Expire Silence modal

'aria-hidden-focus' │ 'serious' │ 'Ensures aria-hidden elements do not contain focusable elements' │ 1 │{code}
    delete project

You can run these tests in the Cypress Test Runner and click on the a11y violations to see more info. in the Dev-Console, Console. (see attachement)

Comment 1 David Taylor 2020-12-04 14:59:19 UTC
Decided not to backport this fix due to (a) turns out this was only a partial fix (https://github.com/openshift/console/pull/7382 truly addresses this issue), and (b) the PR also turns on 'fail CI upon A11y violations detected' which is something we do not want to do so late in the 4.6 release cycle.

Comment 2 Jakub Hadvig 2021-01-11 10:24:00 UTC
Check: https://bugzilla.redhat.com/show_bug.cgi?id=1888430#c1