Bug 1888963
| Summary: | Review Request: crlfuzz - Tool to scan CRLF vulnerability | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Andy Mender <andymenderunix> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | andymenderunix, package-review |
| Target Milestone: | --- | Flags: | andymenderunix:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-07 02:10:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563471 | ||
|
Description
Fabian Affolter
2020-10-16 15:46:28 UTC
All good. Package approved. Full review below:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/crlfuzz/crlfuzz/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-dwisiswant0-crlfuzz-devel
Review: I don't think this is needed. The -devel package is source-only
and does not require components from the binary package.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: crlfuzz-1.4.0-1.fc34.x86_64.rpm
golang-github-dwisiswant0-crlfuzz-devel-1.4.0-1.fc34.noarch.rpm
crlfuzz-1.4.0-1.fc33.src.rpm
crlfuzz.x86_64: W: no-manual-page-for-binary crlfuzz
golang-github-dwisiswant0-crlfuzz-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dwisiswant0/crlfuzz/.goipath
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (debuginfo)
-------------------
Checking: crlfuzz-debuginfo-1.4.0-1.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
(none): E: no installed packages by name golang-github-dwisiswant0-crlfuzz-devel
(none): E: no installed packages by name crlfuzz-debuginfo
(none): E: no installed packages by name crlfuzz
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
Source checksums
----------------
https://github.com/dwisiswant0/crlfuzz/archive/v1.4.0/crlfuzz-1.4.0.tar.gz :
CHECKSUM(SHA256) this package : a59cab6172d598f13add41bdbaf33b0dd5063a6ec0d6ef878be4b629589eca6b
CHECKSUM(SHA256) upstream package : a59cab6172d598f13add41bdbaf33b0dd5063a6ec0d6ef878be4b629589eca6b
Requires
--------
crlfuzz (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libpthread.so.0()(64bit)
golang-github-dwisiswant0-crlfuzz-devel (rpmlib, GLIBC filtered):
go-filesystem
golang(github.com/logrusorgru/aurora)
golang(github.com/projectdiscovery/gologger)
Provides
--------
crlfuzz:
crlfuzz
crlfuzz(x86-64)
golang-github-dwisiswant0-crlfuzz-devel:
golang(github.com/dwisiswant0/crlfuzz/internal/runner)
golang(github.com/dwisiswant0/crlfuzz/pkg/crlfuzz)
golang(github.com/dwisiswant0/crlfuzz/pkg/errors)
golang(github.com/dwisiswant0/crlfuzz/pkg/request)
golang-github-dwisiswant0-crlfuzz-devel
golang-ipath(github.com/dwisiswant0/crlfuzz)
Thanks for the review. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/crlfuzz FEDORA-2020-472a4fa27a has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-472a4fa27a FEDORA-2020-472a4fa27a has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-472a4fa27a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-472a4fa27a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-472a4fa27a has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |