Bug 1888966

Summary:	Review Request: golang-github-muesli-termenv - Advanced ANSI style & color support for your terminal applications
Product:	[Fedora] Fedora	Reporter:	Joe Doss <joe>
Component:	Package Review	Assignee:	Olivier Lemasle <o.lemasle>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	33	CC:	mail, o.lemasle, package-review
Target Milestone:	---	Flags:	o.lemasle: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-06 14:20:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1888967

Description Joe Doss 2020-10-16 16:05:32 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708576-golang-github-muesli-termenv/golang-github-muesli-termenv.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-33-x86_64/01708576-golang-github-muesli-termenv/golang-github-muesli-termenv-0.7.2-1.fc33.src.rpm

Description: Advanced ANSI style & color support for your terminal applications.

Fedora Account System Username: jdoss

Comment 1 Olivier Lemasle 2020-10-27 18:46:30 UTC

Thanks, package approved.

However, please update to latest version 0.7.4.

- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok
- Documentation ok



Rpmlint
-------
Checking: golang-github-muesli-termenv-devel-0.7.2-1.fc34.noarch.rpm
          golang-github-muesli-termenv-0.7.2-1.fc34.src.rpm
golang-github-muesli-termenv-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/muesli/termenv/.goipath
golang-github-muesli-termenv.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


Rpmlint (installed packages)
----------------------------
golang-github-muesli-termenv-devel.noarch: W: invalid-url URL: https://github.com/muesli/termenv <urlopen error [Errno -3] Temporary failure in name resolution>
golang-github-muesli-termenv-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/muesli/termenv/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 2 Gwyn Ciesla 2020-10-27 20:00:59 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-muesli-termenv